H7B3: Split DAC1/2 REC, remove LPTIM45 #499
Conversation
|
Hmm, removing lptims didn't work. |
This is an annoying problem due to using YAML, but basically you have duplicated the RCC key, and only the second instance survives (the merging we do for included files can't work inside a single file). You also can't just combine the two RCC elements as the APB4* registers would then also be defined twice and only the second would survive; you need to move the |
There was a problem hiding this comment.
Thanks! Looks good now. From a quick check it seems the EXTI TODO is just some enumerated values, which is a bit fiddly to remove and I don't think is a major concern for right now, so I'm going to get this merged and the release done.
I noticed the resetValues weren't taking effect because they have to be specified in a higher-level _modify block (not alongside fields), and also they are case sensitive (must be resetValue) and also it turns out they need to be specified with the names prior to renaming those registers because of how the merges work. We could probably do with better error/warning diagnostics around this sort of thing...
bors merge
|
Thanks for helping to get this in before the release! |
No description provided.