Support vue hybrid mode #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e51421 to
5f4f3da
Compare
|
@predragnikolic it seems like there will always be some magic which could go wrong (as mentioned in comment). Does it make sense to have some specific install command instead of phantom which will set up everything for the user in Vue and TypeScript settings, either in global settings or per-project settings? This will all be described and mentioned in documentation. If something changes (e.g. Node gets updated to new version), user should rerun the command to get updated options. This way we avoid any magic and leave everything to users, but I guess this shouldn’t change that much if it’s set up properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different attempt to fix #130
#2523 tried to introduce a new API in order to address #130,
that new API would exist only for the purpose to solve hybridMode for vue and maybe we would not need it for anything else.
This PR makes the minimal changes in order to make hybrid mode work without introducing any new plugin API.
Here is the bad:
vue.hybridModethey need to restart ST. I didn't add logic to LSP-vue to restart the LSP-typescript server. (I tried to add such logic but I wasn't successful, feel free to add if you know/can.)Overall I like the approach. I do not consider the code to be difficult and I consider that the good overweights the bad.
If LSP-vue changes the approach in the future we can just delete this code in LSP-vue and LSP-typescript.