-
-
Notifications
You must be signed in to change notification settings - Fork 53
feat: replaced no-navigation-without-base with no-navigation-without-resolve #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: replaced no-navigation-without-base with no-navigation-without-resolve #1289
Conversation
🦋 Changeset detectedLatest commit: de424c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
3cc4ae5
to
dbbf1da
Compare
ed885b7
to
592b568
Compare
Hey @ota-meshi @baseballyama, sorry to ping you, but I'm getting the same CI error as in #1287, I'm not sure if I'm doing something wrong or it's another issue with the repo... ? |
Also, I'll be away for the next 2 weeks, so I won't be able to respond or fix anything. But I've enabled editing by maintainers, so if you want, feel free to edit the PR and merge it while I'm away :) |
592b568
to
a911940
Compare
a911940
to
de424c6
Compare
Hello, sorry to ping, but can anyone please look at this? It's blocking users from updating SvelteKit... |
de424c6
to
7d993da
Compare
Additionally, I think we should add this rule to the recommended set - with it being limited to SvelteKit files, I don't think there is a good reason not to... |
Fixes #1277
Unfortunately in order to really make sense, the rule needed a new name, so we have yet another deprecated rule :/ Maybe remove them in a major release?