Skip to content

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Aug 7, 2025

Fixes #1277

Unfortunately in order to really make sense, the rule needed a new name, so we have yet another deprecated rule :/ Maybe remove them in a major release?

Copy link

changeset-bot bot commented Aug 7, 2025

🦋 Changeset detected

Latest commit: e3001b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@e3001b3

Published Instant Preview Packages:

View Commit

@marekdedic marekdedic force-pushed the no-navigation-without-resolve branch 3 times, most recently from 3cc4ae5 to dbbf1da Compare August 7, 2025 21:27
@marekdedic marekdedic marked this pull request as ready for review August 7, 2025 21:28
@marekdedic marekdedic force-pushed the no-navigation-without-resolve branch 2 times, most recently from ed885b7 to 592b568 Compare August 7, 2025 21:31
@marekdedic
Copy link
Contributor Author

Hey @ota-meshi @baseballyama, sorry to ping you, but I'm getting the same CI error as in #1287, I'm not sure if I'm doing something wrong or it's another issue with the repo... ?

@marekdedic
Copy link
Contributor Author

Also, I'll be away for the next 2 weeks, so I won't be able to respond or fix anything. But I've enabled editing by maintainers, so if you want, feel free to edit the PR and merge it while I'm away :)

@marekdedic marekdedic force-pushed the no-navigation-without-resolve branch from 592b568 to a911940 Compare August 8, 2025 07:46
@marekdedic marekdedic force-pushed the no-navigation-without-resolve branch from a911940 to de424c6 Compare August 8, 2025 07:48
@marekdedic
Copy link
Contributor Author

Hello, sorry to ping, but can anyone please look at this? It's blocking users from updating SvelteKit...

@marekdedic marekdedic force-pushed the no-navigation-without-resolve branch from de424c6 to 7d993da Compare August 23, 2025 22:30
@marekdedic
Copy link
Contributor Author

Additionally, I think we should add this rule to the recommended set - with it being limited to SvelteKit files, I don't think there is a good reason not to...

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
It looks almost good, but I removed the incorrect since in the documentation.
Could you please run pnpm run update?

@marekdedic
Copy link
Contributor Author

Thanks, should be there :)

@marekdedic marekdedic requested a review from ota-meshi September 3, 2025 07:16
@marekdedic
Copy link
Contributor Author

Ugh, there's some error in the CI, but I don't think it's my error...

@ota-meshi
Copy link
Member

Hmm? Was there a CI error?

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good anyway, so I'll merge it. Thanks!

@ota-meshi ota-meshi merged commit e2e791f into sveltejs:main Sep 3, 2025
17 of 18 checks passed
@marekdedic marekdedic deleted the no-navigation-without-resolve branch September 3, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new resolve function instead of base variable in svelte/no-navigation-without-base
2 participants