fix: correctly set the URL when navigating during a navigation #14004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12809
This PR ensures that the correct navigation results are computed if the user tries to navigate during an ongoing navigation.
The root cause of the issue is that the
page_changed
value is evaluated incorrectly when we try navigating to a page we're already navigating to. This is because thecurrent.url
is updated to the new page before navigation is completed. Therefore, if we click the same link while navigation is pending (due to a lengthyonNavigate
execution), the router will think we're already on the page we're navigating to and return the wrong navigation result. We fix this bychanging it to compare theupdatingurl
we're navigating to with thepage
object'spage.url
property instead, which doesn't actually update until the navigation has completed.current.url
only after allonNavigate
callbacks have completed.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits