Skip to content

fix: correctly set the URL when navigating during a navigation #14004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jul 16, 2025

fixes #12809

This PR ensures that the correct navigation results are computed if the user tries to navigate during an ongoing navigation.

The root cause of the issue is that the page_changed value is evaluated incorrectly when we try navigating to a page we're already navigating to. This is because the current.url is updated to the new page before navigation is completed. Therefore, if we click the same link while navigation is pending (due to a lengthy onNavigate execution), the router will think we're already on the page we're navigating to and return the wrong navigation result. We fix this by changing it to compare the url we're navigating to with the page object's page.url property instead, which doesn't actually update until the navigation has completed. updating current.url only after all onNavigate callbacks have completed.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: c044032

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I quickly checked #9605 which added the code in-between but I don't see a reason why it was on purpose.

@dummdidumm dummdidumm merged commit fda0165 into main Jul 21, 2025
21 checks passed
@dummdidumm dummdidumm deleted the fix-pending-navigation-url branch July 21, 2025 10:15
@github-actions github-actions bot mentioned this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clicking link while onNavigate is pending toggles the URL
2 participants