chore: cleanup code #189
Merged
chore: cleanup code #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
reviewed
Jan 23, 2023
|
|
||
| /** @type {'idle' | 'renaming'} */ | ||
| let state = 'idle'; | ||
| let editing_state = 'idle'; |
There was a problem hiding this comment.
should we just make this a boolean?
Merged
Rich-Harris
reviewed
Jan 23, 2023
Comment on lines
39
to
62
| if (state.status === 'set' || state.status === 'switch') { | ||
| loading = true; | ||
|
|
||
| try { | ||
| clearTimeout(timeout); | ||
| await reset_adapter(state.stubs); | ||
|
|
||
| if (state.status === 'switch') { | ||
| set_iframe_src(adapter.base + path); | ||
| } | ||
|
|
||
| initial = false; | ||
| } catch (e) { | ||
| error = /** @type {Error} */ (e); | ||
| console.error(e); | ||
| } | ||
|
|
||
| loading = false; | ||
| } else if (state.status === 'update' && state.last_updated) { | ||
| const reload = await adapter.update([state.last_updated]); | ||
| if (reload) { | ||
| schedule_iframe_reload(); | ||
| } | ||
| } |
There was a problem hiding this comment.
this stuff feels racy — i feel like this logic belongs elsewhere, though i don't have a great design to offer right now
There was a problem hiding this comment.
The race conditions should be handled internally in adapter.js, though I now realize I'm not making use of the "cancelled" outcome here
Rich-Harris
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #139
Output.svelteadapter.jsstate.jswith proper functions instead of writing to different writables all other the place