possible tweaks #192
Merged
possible tweaks #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
added a commit
that referenced
this pull request
Jan 24, 2023
* create state writable, split out adapter stuff into output component * move filetree into slug route * move solution/constraints into state * move completion into derived store * fix select/completion * wording * move scope into state, cleanup * move icons * code style * possible tweaks (#192) * fixes Co-authored-by: Rich Harris <hello@rich-harris.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestions for #189 — calling
updateandsetdirectly feels slightly nicer to me than having a_statevariable floating around, and creating a new state object seems somehow nicer than mutating the existing one.also, replaces
editing_state: 'idle' | 'remaining'withrenaming: boolean