Skip to content

docs: corrections #16550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
Merged

docs: corrections #16550

merged 3 commits into from
Aug 5, 2025

Conversation

DePasqualeOrg
Copy link
Contributor

This PR corrects two grammatical issues:

  • A few instances of a missing hyphen in "server-side rendering"
  • A common mistake in which "as such" is used as a synonym for "therefore", "thus", "so", "this means that", "for this reason", etc.

To illustrate the second issue, this sentence uses "as such" correctly:

reroute is considered a pure, idempotent function. As such, it must always return the same output for the same input and not have side effects.

The rule of thumb is that "such" should be able to be replaced with a noun phrase from the previous sentence:

reroute is considered a pure, idempotent function. As [a pure, idempotent function], it must always return the same output for the same input and not have side effects.

This sentence uses "as such" incorrectly:

For instance, if condition is true in the code snippet below, the code inside the if block will run and color will be evaluated. As such, changes to either condition or color will cause the effect to re-run.

In this case, I've replaced "As such" with "This means that", since "such" does not refer to an aforementioned noun phrase that could logically be the subject of the sentence. "as such" is not a synonym for "this means that":

For instance, if condition is true in the code snippet below, the code inside the if block will run and color will be evaluated. This means that changes to either condition or color will cause the effect to re-run.

Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: 55f49c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

github-actions bot commented Aug 5, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16550

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eltigerchino eltigerchino merged commit a3f1835 into sveltejs:main Aug 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants