-
Notifications
You must be signed in to change notification settings - Fork 27
Fix the Swift versions list for Windows #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
At one point there was an issue with the 5.10 Windows docker image, I don't recall what the issue was, but will have to watch how actions for projects using windows docker like https://github.com/swiftlang/swift-format react |
Noted @award999. If we need to remove it again we should do it in a way that looks intentional. |
#72 is what removed 5.10. I am not aware that we produced a new docker image for 5.10, so I am fairly certain that adding 5.10 will cause testing on 5.10 with Windows to fail for projects that adopt it. I would advise against adding 5.10 back in unless we have verified that it works. If I remember correctly, I was able to reproduce the issue with the image locally as well. |
Ya I'd say that the build output looks off https://github.com/swiftlang/github-workflows/actions/runs/16629101032/job/47053544826?pr=141#step:9:65. Not sure why that didn't fail the verify job though |
Output from the other Windows docker images look fine in the verifier jobs but I would not merge this |
Is there a way to massage the absence so that it doesn't look like an omission? |
Could you open a PR to add a comment explaining what we said above? Or maybe re-purpose this one? |
Added a comment explaining the omission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
I don't know why it was failing. But it would definitely be failing now because of the missing SDK in the latest build tools. Not sure if that was also the same reason - |
5.10 was omitted. This adds a comment explaining the omission.