Skip to content

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jul 30, 2025

5.10 was omitted. This adds a comment explaining the omission.

@glessard glessard requested a review from a team as a code owner July 30, 2025 17:09
@award999
Copy link
Contributor

At one point there was an issue with the 5.10 Windows docker image, I don't recall what the issue was, but will have to watch how actions for projects using windows docker like https://github.com/swiftlang/swift-format react

@glessard
Copy link
Contributor Author

Noted @award999. If we need to remove it again we should do it in a way that looks intentional.

@ahoppen
Copy link
Member

ahoppen commented Jul 31, 2025

#72 is what removed 5.10. I am not aware that we produced a new docker image for 5.10, so I am fairly certain that adding 5.10 will cause testing on 5.10 with Windows to fail for projects that adopt it. I would advise against adding 5.10 back in unless we have verified that it works. If I remember correctly, I was able to reproduce the issue with the image locally as well.

@award999
Copy link
Contributor

Ya I'd say that the build output looks off https://github.com/swiftlang/github-workflows/actions/runs/16629101032/job/47053544826?pr=141#step:9:65. Not sure why that didn't fail the verify job though

@award999
Copy link
Contributor

Output from the other Windows docker images look fine in the verifier jobs but I would not merge this

@glessard
Copy link
Contributor Author

glessard commented Aug 1, 2025

Is there a way to massage the absence so that it doesn't look like an omission?
It simply doesn't look intentional.

@ahoppen
Copy link
Member

ahoppen commented Aug 4, 2025

Could you open a PR to add a comment explaining what we said above? Or maybe re-purpose this one?

@glessard
Copy link
Contributor Author

glessard commented Aug 6, 2025

Added a comment explaining the omission.

@glessard glessard requested a review from FranzBusch August 6, 2025 17:24
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@ahoppen ahoppen merged commit 1f5e7cd into swiftlang:main Aug 6, 2025
46 checks passed
@bnbarham
Copy link
Contributor

bnbarham commented Aug 14, 2025

Ya I'd say that the build output looks off https://github.com/swiftlang/github-workflows/actions/runs/16629101032/job/47053544826?pr=141#step:9:65

I don't know why it was failing. But it would definitely be failing now because of the missing SDK in the latest build tools. Not sure if that was also the same reason - invalid manifest matches that, though I would have expected a little more output (ie. for the missing libraries, as in https://github.com/apple/swift-numerics/actions/runs/16943623923/job/48018951798). Do we have any issue to add 5.10 back in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants