Fix #16 - gzopen() / gzopen64() - 32 bit builds of Ubuntu 14.04 #17
Conversation
| function gzseek($zp , $offset, $whence = SEEK_SET) { return gzseek64($zp, $offset, $whence); } | ||
| } | ||
| if (!function_exists('gztell') && function_exists('gztell64')) { | ||
| function gztell($zp) { return gztell64($zp); } |
There was a problem hiding this comment.
return p\Php56::gztell64($zp); ?
There was a problem hiding this comment.
i'm ok with not duplicating the function as static method in the Php56 class (reduces boiler plates)
There was a problem hiding this comment.
more consistency and easier to test when moved into Php56
There was a problem hiding this comment.
I wonder @keradus how would you test that? We'd need the broken ubuntu isn't it?
|
adding some tests would be awesome! |
|
The travis failure is not in my code ;-) It looks like php-7 is using phpunit-5, but perhaps the tests were written for phpunit-4 |
|
ref #15 ( and #15 (comment) ) |
| // Missing functions in PHP 5.5.9 - affects 32 bit builds of Ubuntu 14.04LTS | ||
| // See https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1315888 | ||
| if (!function_exists('gzopen') && function_exists('gzopen64')) { | ||
| function gzopen($filename , $mode = 'r', $use_include_path = 0 ) { return gzopen64($filename, $mode, $use_include_path); } |
There was a problem hiding this comment.
$mode doesn't default to 'r' per the doc (http://php.net/gzopen)
trailing space before )
There was a problem hiding this comment.
and shouldn't $use_include_path be a boolean instead ?
There was a problem hiding this comment.
ah no, they use a crappy int API instead of a proper boolean
|
The Travis failure is because of a BC break in PHPUnit 5.1 |
Since we are working around a platform-specific problem, I'm not sure how we create a meaningful test? To trigger the code, we'd need to create a situation where the function Besides, none of the other "thin wrappers" have unit tests. FYI, I've tested the code on a VM... |
Oops. My bad. Fixed |
| function gzopen($filename , $mode, $use_include_path = 0) { return gzopen64($filename, $mode, $use_include_path); } | ||
| } | ||
| if (!function_exists('gzseek') && function_exists('gzseek64')) { | ||
| function gzseek($zp , $offset, $whence = SEEK_SET) { return gzseek64($zp, $offset, $whence); } |
There was a problem hiding this comment.
extra space before first comma
|
👍 |
|
Thank you @fisharebest. |
This PR was merged into the 1.1-dev branch. Discussion ---------- Add CHANGELOG Fixes #32 * v1.1.1 * bug #40 [Apcu] Load APCUIterator only when APCIterator exists (nicolas-grekas) * bug #37 [Iconv] Fix wrong use in bootstrap.php (tucksaun) * bug #31 Fix class_uses polyfill (WouterJ) * v1.1.0 * feature #22 [APCu] A new polyfill for the legacy APC users (nicolas-grekas) * bug #28 [Php70] Workaround https://bugs.php.net/63206 (nicolas-grekas) * v1.0.1 * bug #14 ldap_escape does not encode leading/trailing spaces. (ChadSikorra) * bug #17 Fix #16 - gzopen() / gzopen64() - 32 bit builds of Ubuntu 14.04 (fisharebest) * v1.0.0 * Hello symfony/polyfill Commits ------- 1781007 Add CHANGELOG
Fix for #16