[Apcu] Load APCUIterator only when APCIterator exists #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
| @@ -26,3 +26,13 @@ function apcu_inc($key, $step = 1, &$success = false) { return apc_inc($key, $st | |||
| function apcu_sma_info($limited = false) { return apc_sma_info($limited); } | |||
| function apcu_store($key, $var = null, $ttl = 0) { return apc_store($key, $var, $ttl); } | |||
| } | |||
|
|
|||
| if (!class_exists('APCUIterator', false)) { | |||
There was a problem hiding this comment.
Actually, the condition should also check for APCIterator, otherwise it does not fix the bug (and makes it more widespread as this is not autoloaded anymore but eagerly loaded)
There was a problem hiding this comment.
I though that the existing check in https://github.com/symfony/polyfill/pull/40/files#diff-af8f2afac0a67b224b25386b2a75cc16R12 would be enough.
I don't get why, but it looks like it's not true... hhvm?
There was a problem hiding this comment.
also, APCIterator is available from PECL apc >= 3.1.1, so it doesn't exist on 3.0 for example
Merged
fabpot
added a commit
that referenced
this pull request
Mar 10, 2016
This PR was merged into the 1.1-dev branch. Discussion ---------- Add CHANGELOG Fixes #32 * v1.1.1 * bug #40 [Apcu] Load APCUIterator only when APCIterator exists (nicolas-grekas) * bug #37 [Iconv] Fix wrong use in bootstrap.php (tucksaun) * bug #31 Fix class_uses polyfill (WouterJ) * v1.1.0 * feature #22 [APCu] A new polyfill for the legacy APC users (nicolas-grekas) * bug #28 [Php70] Workaround https://bugs.php.net/63206 (nicolas-grekas) * v1.0.1 * bug #14 ldap_escape does not encode leading/trailing spaces. (ChadSikorra) * bug #17 Fix #16 - gzopen() / gzopen64() - 32 bit builds of Ubuntu 14.04 (fisharebest) * v1.0.0 * Hello symfony/polyfill Commits ------- 1781007 Add CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39