This repository was archived by the owner on Feb 6, 2022. It is now read-only.
Use sendmail_path as default value #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite some time ago, Swiftmailer dropped support for the PHP
mailfunction for security reasons and thus forcing you to use eithersendmailorsmtp. However, when usingsendmail, The Swiftmailer Bundle only uses a hard coded command by default, which might not work on all hosting environments out of the box. The PHPmailfunction on the other hand uses the configuredsendmail_pathof the PHP configuration, which most likely will work in the respective hosting environment.This PR simply uses the configured
sendmail_pathas the default value for thecommandparameter of the bundle configuration. Therefore emails should work again out of the box, just like it was before when Swiftmailer still supported PHPmail.Kind of like the poor-man's version of symfony/symfony#36131 ;)