[Mailer] Add a transport that uses php.ini settings for configuration #36131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe6a887 to
741ed9e
Compare
|
I don't think this should be part of the DSN. That's an internal configuration setting, not related to the transport DSN itself. |
741ed9e to
7d3ba72
Compare
|
Usage of a container parameter instead of a dsn option. |
fabpot
reviewed
May 4, 2020
src/Symfony/Bundle/FrameworkBundle/Resources/config/mailer_transports.xml
Outdated
Show resolved
Hide resolved
bfffb9e to
f81c0a6
Compare
fabpot
requested changes
Jun 24, 2020
src/Symfony/Component/Mailer/Transport/NativeTransportFactory.php
Outdated
Show resolved
Hide resolved
|
|
||
| protected function getSupportedSchemes(): array | ||
| { | ||
| $supportedShemes = ['native', 'native+sendmail']; |
There was a problem hiding this comment.
So we really need the 2 possibiliies? Can't we only support native and do the switch ourselves in the code depending on the platform?
There was a problem hiding this comment.
Not really needed indeed; I added the two options to be consistent with SendmailTransportFactory. But I can only keep native if you prefer.
There was a problem hiding this comment.
I would remove the native-sendmail scheme, which is not needed IMHO.
8b504d9 to
65cc5d7
Compare
|
Can't this be solved from the outside, aka by providing a sendmail script wrapper instead? |
fabpot
requested changes
Aug 13, 2020
src/Symfony/Component/Mailer/Transport/NativeTransportFactory.php
Outdated
Show resolved
Hide resolved
49b39fa to
04de561
Compare
|
Updated and CHANGELOG modified |
fabpot
approved these changes
Aug 13, 2020
|
@l-vo Great work as always, can you see if you can add some docs about this feature? |
|
Thank you @l-vo. |
Thank you 🙂 Yes I created my TODO list with the docs for the PR recently merged 😁 |
This was referenced Sep 4, 2020
fabpot
added a commit
to symfony/swiftmailer-bundle
that referenced
this pull request
Sep 27, 2020
This PR was merged into the 3.4-dev branch. Discussion ---------- Use sendmail_path as default value Quite some time ago, Swiftmailer dropped support for the PHP `mail` function for security reasons and thus forcing you to use either `sendmail` or `smtp`. However, when using `sendmail`, The Swiftmailer Bundle only uses a hard coded command by default, which might not work on all hosting environments out of the box. The PHP `mail` function on the other hand uses the configured `sendmail_path` of the PHP configuration, which most likely will work in the respective hosting environment. This PR simply uses the configured `sendmail_path` as the default value for the `command` parameter of the bundle configuration. Therefore emails should work again out of the box, just like it was before when Swiftmailer still supported PHP `mail`. Kind of like the poor-man's version of symfony/symfony#36131 ;) Commits ------- 31a4fed use sendmail_path as default value
Merged
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 21, 2020
This PR was submitted for the 5.x branch but it was squashed and merged into the 5.2 branch instead. Discussion ---------- Complete documentation about mailer integration - Complete framework config reference with `Mailer` (based on #14087 plus `message_bus` and `headers` that was added after 4.4) - Add documentation about `native` DSN protocol (symfony/symfony#36131) Close #14066 Commits ------- a389dfb Complete documentation about mailer integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow to use the mailer when sendmail is not on the
/usr/sbindirectory or when the-bsoption is not supported.