minor #29174 Add required key attribute (greg0ire)

nicolas-grekas · nicolas-grekas · commit 131a42b38ad3 · 2018-11-11T20:41:05.000+01:00
This PR was merged into the 2.8 branch. Discussion ---------- Add required key attribute | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I am getting warnings when running tests with recent phpunit versions (since 7.2.0) : > `- Element 'element': The attribute 'key' is required but missing.` This requirement is far from being new, what is recent is phpunit validating its configuration file against the XSD schema. See sebastianbergmann/phpunit@d4484be This is pedantic (not a bugfix), and might be a bit painful to merge upstream, so if you feel like I should target a more recent instead and let the old branches go on with their lives, please tell me. Commits ------- c0733c2 Add required key attribute
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -56,8 +56,8 @@
                 <array>
                     <element key="time-sensitive">
                         <array>
-                            <element><string>Symfony\Component\Console</string></element>
-                            <element><string>Symfony\Component\HttpFoundation</string></element>
+                            <element key="0"><string>Symfony\Component\Console</string></element>
+                            <element key="1"><string>Symfony\Component\HttpFoundation</string></element>
                         </array>
                     </element>
                 </array>
