Add required key attribute #29174
Merged
Add required key attribute #29174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am getting warnings when running tests with recent phpunit versions: > - Element 'element': The attribute 'key' is required but missing. This requirement is far from being new, what is recent is phpunit validating its configuration file against the XSD schema. See sebastianbergmann/phpunit@d4484be
9dd1cb5 to
c0733c2
Compare
|
🤔 looks like there are more issues to fix: That one is probably an issue with the XSD url being outdate, because I can see these attributes here: https://github.com/sebastianbergmann/phpunit/blob/master/phpunit.xsd I think 5.2 should probably be used here: sebastianbergmann/phpunit@7e06a82 It validates if I use http://schema.phpunit.de/5.2/phpunit.xsd . Composer seems to say lower versions should be allowed though: Line 98 in 46e3745 What is the right call here? I think I should change the url. I also checked the other phpunit config files in the project, they all validate against that version of the XSD: |
|
Let's change the URL yes. Since lowest versions of phpunit don't care about it, there is no issue doing so. |
|
I will make a separate PR for this, since there are a lot more files to change. |
|
See #29175 |
|
Thank you @greg0ire. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 11, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Add required key attribute | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I am getting warnings when running tests with recent phpunit versions (since 7.2.0) : > `- Element 'element': The attribute 'key' is required but missing.` This requirement is far from being new, what is recent is phpunit validating its configuration file against the XSD schema. See sebastianbergmann/phpunit@d4484be This is pedantic (not a bugfix), and might be a bit painful to merge upstream, so if you feel like I should target a more recent instead and let the old branches go on with their lives, please tell me. Commits ------- c0733c2 Add required key attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting warnings when running tests with recent phpunit versions (since 7.2.0) :
This requirement is far from being new, what is recent is phpunit
validating its configuration file against the XSD schema.
See sebastianbergmann/phpunit@d4484be
This is pedantic (not a bugfix), and might be a bit painful to merge upstream, so if you feel like I should target a more recent instead and let the old branches go on with their lives, please tell me.