Skip to content

Failing tests on Travis #10821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Apr 30, 2014 · 7 comments
Closed

Failing tests on Travis #10821

stof opened this issue Apr 30, 2014 · 7 comments

Comments

@stof
Copy link
Member

stof commented Apr 30, 2014

Since the upgrade to PHPUnit 4 on Travis, the testsuite is failing for tests involving the session. This should be debugged
@fabpot
Copy link
Member

fabpot commented Apr 30, 2014

The failing tests are not related to the upgrade to PHPUnit 4 but the fact that Travis is now using the phar instead of a PEAR installation.

@romainneutron
Copy link
Contributor

What about installing phpunit with composer global install phpunit/phpunit:~4.0 then run ~/.composer/vendor/bin/phpunit to avoid using the phar one?

@stof
Copy link
Member Author

stof commented Apr 30, 2014

hmm, is there a bug in the PHPUnit phar ?

@perajovic perajovic mentioned this issue Apr 30, 2014
Closed
@stof
Copy link
Member Author

stof commented Apr 30, 2014

OK, it is related to sebastianbergmann/phpunit#1193

@fabpot
Copy link
Member

fabpot commented Apr 30, 2014

@romainneutron As the bug in PHPUnit is not going to be fixed soon (not trivial), can you submit a PR on 2.3 with your proposed solution?

@romainneutron
Copy link
Contributor

I'm on my way to do that, waiting for travis build to submit it

This was referenced Apr 30, 2014
Closed
Merged
@stof
Copy link
Member Author

stof commented Apr 30, 2014

The bug in PHPUnit has been fixed :)

fabpot added a commit that referenced this issue Apr 30, 2014
@fabpot
minor #10826 [2.3] Fix phpunit test suite on travis #2 (romainneutron)
1b6daf3 
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] Fix phpunit test suite on travis #2

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10821
| License       | MIT

This is a second approach to solve #10821.
Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global install

Commits
-------

32e5f67 [DependencyInjection] Fix travis unit tests
c7befd5 Update PHPUnit before run
@stof stof closed this as completed Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @romainneutron @stof