Skip to content

Update the styles of all the built-in command consoles #14138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
33 of 60 tasks
javiereguiluz opened this issue Mar 31, 2015 · 4 comments
Closed
33 of 60 tasks

Update the styles of all the built-in command consoles #14138

javiereguiluz opened this issue Mar 31, 2015 · 4 comments
Labels
Console

Comments

@javiereguiluz
Copy link
Member

Now that #14057 has been merged, we need to update the styles of all the built-in console commands. Let's make a list to coordinate the work:

Commands that will be redesigned later

  • doctrine:cache:clear-metadata
  • doctrine:cache:clear-query
  • doctrine:cache:clear-result
  • doctrine:database:create
  • doctrine:database:drop
  • doctrine:ensure-production-settings
  • doctrine:fixtures:load
  • doctrine:generate:crud
  • doctrine:generate:entities
  • doctrine:generate:entity
  • doctrine:generate:form
  • doctrine:mapping:convert
  • doctrine:mapping:import
  • doctrine:mapping:info
  • doctrine:query:dql
  • doctrine:query:sql
  • doctrine:schema:create
  • doctrine:schema:drop
  • doctrine:schema:update
  • doctrine:schema:validate
  • generate:doctrine:crud
  • generate:doctrine:entities
  • generate:doctrine:entity
  • generate:doctrine:form
  • orm:convert:mapping

Deprecated commands which won't be updated

  • init:acl
@javiereguiluz javiereguiluz mentioned this issue Mar 31, 2015
Closed
@94noni 94noni mentioned this issue Apr 2, 2015
Closed
@ogizanagi ogizanagi mentioned this issue Apr 5, 2015
Merged
@1ed
Copy link
Contributor

1ed commented Apr 6, 2015

I've created a PR for assets:install #14235

fabpot added a commit that referenced this issue Apr 7, 2015
@fabpot
feature #14220 [3.0][Console][OutputStyle] Implements verbosity level…
630a982 
…s methods (ogizanagi)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0][Console][OutputStyle] Implements verbosity levels methods

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A - Travis build for #14032
| License       | MIT

Implements the verbosity level methods from `OutputInterface` for the new `OutputStyle` abstract class in 3.0 branch.
Fixes Travis builds with `deps=high` env var for #14032 PR and future console style updates.

=========
Related to: #14032, #14057, #14138, #14132, #14172, ...

Commits
-------

a30f507 [Console] [OutputStyle] Implements verbosity methods
@stof
Copy link
Member

stof commented Apr 16, 2015

The list you gave here contains lots of commands which are not in the core but in other bundles

@javiereguiluz
Copy link
Member Author

That's right. But this is a meta-issue to simplify tracking which commands are updated and which not.

This was referenced May 8, 2015
Merged
Merged
fabpot added a commit that referenced this issue May 15, 2015
@fabpot
minor #14591 [FrameworkBundle] Applied new styles to the config:debug…
c5fe926 
… & config:dump-reference commands (ogizanagi)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Applied new styles to the config:debug & config:dump-reference commands

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | Partially #14138
| License       | MIT
| Doc PR        | -

Min dependency on `symfony/console` is changed to `~2.7` in the FrameworkBundle, as it will be a requirement in order to update each command provided in this bundle.

Commits
-------

e56a619 [FrameworkBundle] Applied new styles to the config:debug & config:dump-reference commands
fabpot added a commit that referenced this issue May 20, 2015
@fabpot
minor #14595 [FrameworkBundle] Applied new styles to translation comm…
c7e0538 
…ands (ogizanagi)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Applied new styles to translation commands

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | Partially #14138
| License       | MIT
| Doc PR        | -

## Translation debug

_Only the table layout and deprecation note is changed_

![screenshot 2015-05-09 a 17 09 17](https://cloud.githubusercontent.com/assets/2211145/7550802/45f9a53c-f670-11e4-8e33-6ec9de973c99.PNG)
![screenshot 2015-05-09 a 17 13 47](https://cloud.githubusercontent.com/assets/2211145/7551396/d57523e2-f686-11e4-907c-8b4183183ee1.PNG)

## Translation update

### Before:

![screenshot 2015-05-09 a 17 15 51](https://cloud.githubusercontent.com/assets/2211145/7550791/06cee3a4-f670-11e4-80f1-320e2768290c.PNG)

### After:

![screenshot 2015-05-09 a 17 03 59](https://cloud.githubusercontent.com/assets/2211145/7550797/45f3baaa-f670-11e4-9beb-ad6c6b10442c.PNG)
![screenshot 2015-05-09 a 17 04 35](https://cloud.githubusercontent.com/assets/2211145/7550799/45f7ed64-f670-11e4-9b77-9b602ea2920b.PNG)
![screenshot 2015-05-09 a 17 05 06](https://cloud.githubusercontent.com/assets/2211145/7550800/45f97904-f670-11e4-8b60-c73095b74800.PNG)
![screenshot 2015-05-09 a 17 06 07](https://cloud.githubusercontent.com/assets/2211145/7550798/45f6508a-f670-11e4-9c21-7247691df985.PNG)

Commits
-------

812fedc [FrameworkBundle] Applied new styles to translation commands
This was referenced Sep 2, 2015
Closed
Closed
@javiereguiluz
Copy link
Member Author

I'm closing this issue as fixed. All Symfony commands have been updated and the remaining Doctrine commands will be updated in a separate pull request (and some of them in the Doctrine repository).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @1ed @stof @aitboudad