-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Yaml] colon inside comment #16784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was fixed in #16745 (2.8) but was somehow not merged into 3.0. |
Strange, github says that the commit is included in the v2.8.0 and v3.0.0 tags. ping @xabbuh |
@derrabus the commit is included, but conflicts have been resolved the wrong way, leading to loosing the bugfix in 3.0. I already have it passing again locally |
This PR was merged into the 3.0 branch. Discussion ---------- Reapply the Yaml bugfix of #16745 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16784 | License | MIT | Doc PR | n/a The fix done in #16745 was missed when resolving conflicts during the merge to 3.0 Commits ------- d9393d8 Reapply the Yaml bugfix of #16745
Im still getting this error on 2.8. Not sure if thats expected, but looking at this thread it doesnt seem so.
Filename: FOSUserBundle.bg.yml
|
@matthbull you got a colon just after "адрес" You need to quote the whole line
|
Hi, i was getting it from a comment in config.xml in 2.8 while running phpunit... solved thanks to this issue :) fos_oauth_server: db_driver: orm # Driver availables: orm, mongodb, or propel |
@benji07 yes, I know it needs quoting, but its in a vendor bundle so I cant. And seeing as it seems to be the same initial issue I thought Id mention it. |
@matthbull Looks like this was fixed in FOSUserBundle with FriendsOfSymfony/FOSUserBundle#1990. |
I got an error after updating to symfony3
The text was updated successfully, but these errors were encountered: