Skip to content

[Yaml] colon inside comment #16784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benji07 opened this issue Dec 1, 2015 · 8 comments
Closed

[Yaml] colon inside comment #16784

benji07 opened this issue Dec 1, 2015 · 8 comments
Labels

Comments

@benji07
Copy link
Contributor

benji07 commented Dec 1, 2015

I got an error after updating to symfony3

A colon cannot be used in an unquoted mapping value.
at Parser->parseValue('true # default: false', false, false, false, 'mapping') in Parser.php line 231

elao_error_notifier:
    handle404: true # default: false
@ghost
Copy link

ghost commented Dec 1, 2015

This was fixed in #16745 (2.8) but was somehow not merged into 3.0.

@derrabus
Copy link
Member

derrabus commented Dec 1, 2015

Strange, github says that the commit is included in the v2.8.0 and v3.0.0 tags.

bildschirmfoto 2015-12-01 um 16 41 39

ping @xabbuh

@stof
Copy link
Member

stof commented Dec 1, 2015

@derrabus the commit is included, but conflicts have been resolved the wrong way, leading to loosing the bugfix in 3.0. I already have it passing again locally

@xabbuh xabbuh added the Yaml label Dec 1, 2015
stof added a commit that referenced this issue Dec 2, 2015
This PR was merged into the 3.0 branch.

Discussion
----------

Reapply the Yaml bugfix of #16745

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16784
| License       | MIT
| Doc PR        | n/a

The fix done in #16745 was missed when resolving conflicts during the merge to 3.0

Commits
-------

d9393d8 Reapply the Yaml bugfix of #16745
@stof stof closed this as completed Dec 2, 2015
@matthbull
Copy link

Im still getting this error on 2.8. Not sure if thats expected, but looking at this thread it doesnt seem so.

[Symfony\Component\Yaml\Exception\ParseException]
A colon cannot be used in an unquoted mapping value at line 72 (near "check_email: Изпратихме писмо с линк за активация на посочения
E-mail адрес: %email%. Ако не откривате писмото проверете и в папка СПАМ.").

Filename: FOSUserBundle.bg.yml

resetting:
    password_already_requested: Този потребител вече е поискал смяна на парола в последните 24 часа.
    check_email: Изпратихме писмо с линк за активация на посочения E-mail адрес: %email%. Ако не откривате писмото проверете и в папка СПАМ.

@benji07
Copy link
Contributor Author

benji07 commented Jan 8, 2016

@matthbull you got a colon just after "адрес"

You need to quote the whole line

resetting:
    password_already_requested: Този потребител вече е поискал смяна на парола в последните 24 часа.
    check_email: "Изпратихме писмо с линк за активация на посочения E-mail адрес: %email%. Ако не откривате писмото проверете и в папка СПАМ."

@silverjebs
Copy link

Hi, i was getting it from a comment in config.xml in 2.8 while running phpunit... solved thanks to this issue :)

fos_oauth_server:
    db_driver: orm       # Driver availables: orm, mongodb, or propel

@matthbull
Copy link

@benji07 yes, I know it needs quoting, but its in a vendor bundle so I cant. And seeing as it seems to be the same initial issue I thought Id mention it.

@xabbuh
Copy link
Member

xabbuh commented Jan 12, 2016

@matthbull Looks like this was fixed in FOSUserBundle with FriendsOfSymfony/FOSUserBundle#1990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants