[Yaml] look for colon in parsed inline string #16745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking for a colon in an unquoted mapping value can lead to falsely reported parse errors (e.g. when a comment after the mapping value contains a colon).
|
I stumbled about those errors, I think it would be helpful to mention the file, otherwise you just know the line number and not even the value. Upgrading it is not very easy. |
|
@peterrehm Adding the file in exceptions is done by the main Yaml class, which is the only one to know the file. The Parser class only deals with strings. So, adding the file to the deprecation notices would be very difficult. |
|
Thank you @xabbuh. |
|
@fabpot To upgrade locally I added the value to the message and then I knew where to upgrade, otherwise it was just impossible for me to find out what to upgrade. Mabe this is an option. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Yaml] look for colon in parsed inline string | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16562 | License | MIT | Doc PR | Looking for a colon in an unquoted mapping value can lead to falsely reported parse errors (e.g. when a comment after the mapping value contains a colon). Commits ------- 2127058 [Yaml] look for colon in parsed inline string
|
I submitted a PR for the improvements, let me know your thoughts. |
stof
added a commit
to stof/symfony
that referenced
this pull request
Dec 1, 2015
stof
added a commit
that referenced
this pull request
Dec 2, 2015
This PR was merged into the 3.0 branch. Discussion ---------- Reapply the Yaml bugfix of #16745 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16784 | License | MIT | Doc PR | n/a The fix done in #16745 was missed when resolving conflicts during the merge to 3.0 Commits ------- d9393d8 Reapply the Yaml bugfix of #16745
stof
added a commit
that referenced
this pull request
Dec 5, 2015
* 3.0: Set the redraw frequency at least to 1. Setting it to 0 would otherwise produce an error. [Form] document changes to form type interfaces [Process] Unset callback after stop to free memory Improve error message for undefined DIC aliases [VarDumper] fixed .sf-dump z-index [Validator] Updated Luxembourgish translations for 2.8 Disallow http-kernel 3.x, fixes #16837. [Config] Throw an exception when using cannotBeEmpty() on numeric or boolean nodes [DependencyInjection] Validate class names and factory methods ampq → amqp Fix typo Refactoring EntityUserProvider::__construct() to not do work, cause cache warm error [Form] Add context to FormFactory deprecations Reapply the Yaml bugfix of #16745 CS: remove unneeded parentheses around control statements [DomCrawler] add upgrade hint on interface changes [TwigBridge] Clean deps now that 2.8.0 is tagged
stof
added a commit
that referenced
this pull request
Dec 5, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [DX][YAML] Improved Deprecation Notices Show the actual invalid string for the Yaml deprecations to ease the upgrade as you can grep the strings. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Related #16745 Commits ------- 3179407 Improved error messages for Yaml Deprecations
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for a colon in an unquoted mapping value can lead to falsely
reported parse errors (e.g. when a comment after the mapping value
contains a colon).