[monolog-bridge] 2.8 allows http-kernel 3.0 but uses interface that has been removed #16837
Comments
|
The commit cannot be backported to 2.8 as it would be a bc break. So the other solution seems right. |
derrabus
added a commit
to derrabus/symfony
that referenced
this issue
Dec 5, 2015
|
I've submitted a PR that fixes the composer.json file. But we should probably add a test that actually instantiates the |
stof
added a commit
that referenced
this issue
Dec 5, 2015
…tpKernel 3.0 (derrabus) This PR was merged into the 2.8 branch. Discussion ---------- [MonologBridge] Monolog Bridge 2.8 is incompatible with HttpKernel 3.0 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16837 | License | MIT | Doc PR | none Greetings from the SymfonyCon hackday. I wanted to start my day with an easy PR. 😉 As pointed out by @anlutro in #16837, MonologBridge 2.8 uses a deprecated interface of HttpKernel that has been removed in 3.0. Because of this, MonologBridge 2.8 must not be marked as compatible with HttpKernel 3.0 in composer.json. Commits ------- cb8d2c3 Disallow http-kernel 3.x, fixes #16837.
stof
added a commit
that referenced
this issue
Dec 5, 2015
* 2.8: Set the redraw frequency at least to 1. Setting it to 0 would otherwise produce an error. [Process] Unset callback after stop to free memory Improve error message for undefined DIC aliases [VarDumper] fixed .sf-dump z-index [Validator] Updated Luxembourgish translations for 2.8 Disallow http-kernel 3.x, fixes #16837. [DependencyInjection] Validate class names and factory methods ampq → amqp Fix typo Refactoring EntityUserProvider::__construct() to not do work, cause cache warm error [Form] Add context to FormFactory deprecations CS: remove unneeded parentheses around control statements [TwigBridge] Clean deps now that 2.8.0 is tagged
stof
added a commit
that referenced
this issue
Dec 5, 2015
* 3.0: Set the redraw frequency at least to 1. Setting it to 0 would otherwise produce an error. [Form] document changes to form type interfaces [Process] Unset callback after stop to free memory Improve error message for undefined DIC aliases [VarDumper] fixed .sf-dump z-index [Validator] Updated Luxembourgish translations for 2.8 Disallow http-kernel 3.x, fixes #16837. [Config] Throw an exception when using cannotBeEmpty() on numeric or boolean nodes [DependencyInjection] Validate class names and factory methods ampq → amqp Fix typo Refactoring EntityUserProvider::__construct() to not do work, cause cache warm error [Form] Add context to FormFactory deprecations Reapply the Yaml bugfix of #16745 CS: remove unneeded parentheses around control statements [DomCrawler] add upgrade hint on interface changes [TwigBridge] Clean deps now that 2.8.0 is tagged
stof
added a commit
that referenced
this issue
Dec 5, 2015
…derrabus) This PR was merged into the 2.3 branch. Discussion ---------- [MonologBridge] Added a test case for the Logger class | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none So far, there is no test case that ensures that the `Symfony\Bridge\Monolog\Logger` can be instantiated. Because of this, bug #16837 was not discovered by the tests. This PR adds a simple test case that tests some basic functionality of that particular class. Commits ------- 78c0a6e Added a test case for the Logger class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The package
symfony/monolog-bridgein version 2.8 has a requirement forsymfony/http-kernel ~2.4|~3.0.0, but it uses an interface that has been removed in 3.0.As far as I can tell, either the version constraint should be fixed, or this commit should be backported into 2.8.
The text was updated successfully, but these errors were encountered: