Skip to content

Toolbar error when using dev-master #20829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FrancescoBorzi opened this issue Dec 8, 2016 · 4 comments
Closed

Toolbar error when using dev-master #20829

FrancescoBorzi opened this issue Dec 8, 2016 · 4 comments
Labels
Bug Status: Needs Review Unconfirmed WebProfilerBundle

Comments

@FrancescoBorzi
Copy link
Contributor

The dev toolbar is broken in dev-master, it gives error:

Block "menu" on template "@WebProfiler/Profiler/base.html.twig" does not exist in @WebProfiler/Profiler/base.html.twig at line 17.

that happens only when using:

"symfony/symfony": "dev-master",

problem is not there using:

"symfony/symfony": "~3.2.0",
@stof
Copy link
Member

stof commented Dec 8, 2016

@javiereguiluz I suspect this is rleated to using Twig 2.x, which does not allow rendering non-existent blocks anymore.

@stof stof mentioned this issue Dec 8, 2016
Merged
nicolas-grekas added a commit that referenced this issue Dec 8, 2016
@nicolas-grekas
bug #20831 [Twig] Fix deprecations with Twig 1.29 (nicolas-grekas)
be5a5e4 
This PR was merged into the 2.7 branch.

Discussion
----------

[Twig] Fix deprecations with Twig 1.29

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20829
| License       | MIT
| Doc PR        | -

Commits
-------

9218cac [Twig] Fix deprecations with Twig 1.29
@FrancescoBorzi
Copy link
Contributor Author

Thanks for the PR, unfortunately the bug persists.

"name": "symfony/symfony",
            "version": "dev-master",
            "source": {
                "type": "git",
                "url": "https://github.com/symfony/symfony.git",
                "reference": "9091a82b66c6cf70d672868bedaf0a92be884c51"
            },

name": "twig/twig",
            "version": "2.x-dev",
            "source": {
                "type": "git",
                "url": "https://github.com/twigphp/Twig.git",
                "reference": "31801a18cee4ae16e013a7e1623ce999c96b3fa3"
            },

@stof
Copy link
Member

stof commented Dec 8, 2016

@ShinDarth the fix is in 2.7, 2.8, 3.1 and 3.2 branches, but not yet in master. Test it with the Symfony 3.2 branch

@FrancescoBorzi
Copy link
Contributor Author

@stof as I said in the report, there is no problem using 3.2 (even before the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Unconfirmed WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @FrancescoBorzi @nicolas-grekas @stof @carsonbot