Skip to content

[PropertyInfo] BC break caused by #21370 #22222

Closed
@teohhanhui

Description

@teohhanhui
Q A
Bug report? no
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.2.6

BC break caused by #21370

Moving PhpDocExtractor before ReflectionExtractor changes behaviour in client code. This is a BC break.

Example:

class TravelDestination
{
    /**
     * @var TravelDestinationType Type of the travel destination.
     *
     * @ORM\Column(type="travel_destination_type_enum", nullable=true)
     */
    protected $type;

    /**
     * Sets type.
     *
     * @param TravelDestinationType $type
     *
     * @return $this
     */
    public function setType(?TravelDestinationType $type)
    {
        $this->type = $type;

        return $this;
    }

    /**
     * Gets type.
     *
     * @return TravelDestinationType|null
     */
    public function getType(): ?TravelDestinationType
    {
        return $this->type;
    }
}

Before:
nullable is true (from ReflectionExtractor)

After:
nullable is false (from PhpDocExtractor)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions