Skip to content

YAML parser: No Escaping of single quotes before newline? #25379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbankmann opened this issue Dec 7, 2017 · 7 comments
Closed

YAML parser: No Escaping of single quotes before newline? #25379

dbankmann opened this issue Dec 7, 2017 · 7 comments
Labels
Bug Status: Needs Review Yaml
Milestone
3.4

Comments

@dbankmann
Copy link

Q A
Bug report? yes
Feature request? no
BC Break report? yes/no
RFC? yes/no
Symfony version dcf3a9dfac146a0e10757a91de0b541fcd79de4f

Hi, with the following yaml file

key:
    fields:
        title: 'bla. Users''
            Guide'

I get the Malformed inline YAML string exception. The file should be valid yaml though.
@xabbuh xabbuh added this to the 3.3 milestone Dec 7, 2017
@Simperfit
Copy link
Contributor

I can reproduce this, @dbacc Do you want to provide a PR to fix this behaviour ?

@xabbuh
Copy link
Member

xabbuh commented Dec 8, 2017 •
edited by javiereguiluz
Loading

I suggest to not spend any time here. I have a pending patch for #25239 locally which will probably fix this issue too.

@xabbuh xabbuh self-assigned this Dec 8, 2017
@Simperfit
Copy link
Contributor

Ok @xabbuh thanks ;)

@xabbuh xabbuh modified the milestones: 3.3, 3.4 Jan 29, 2018
@xabbuh xabbuh removed their assignment Feb 19, 2019
@Simperfit
Copy link
Contributor

@xabbuh can we close this ?

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2019

@Simperfit It would still be good to have this fixed (and if it were by only throwing a more meaningful error when we detect a quoted string that spans multiple lines).

@Simperfit
Copy link
Contributor

I've done the error since I do not know how to parse this to make it work, maybe this could be a good thing to do in a other hackathon with multiple people ? (I think to do it I need that someone explain me how it works entirely :p).

@Simperfit Simperfit mentioned this issue Apr 29, 2019
Closed
@xabbuh xabbuh mentioned this issue Apr 29, 2019
Closed
@xabbuh xabbuh mentioned this issue Sep 21, 2019
Merged
@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2019

Can you confirm that #33658 will solve this issue?

@fabpot fabpot closed this as completed Sep 23, 2019
fabpot added a commit that referenced this issue Sep 25, 2019
@fabpot
feature #33658 [Yaml] fix parsing inline YAML spanning multiple lines…
4cf7ec1 
… (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] fix parsing inline YAML spanning multiple lines

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #25239 #25379 #31333
| License       | MIT
| Doc PR        |

Commits
-------

85a5c31 fix parsing inline YAML spanning multiple lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
5 participants
@fabpot @xabbuh @Simperfit @dbankmann @carsonbot