Skip to content

[Cache] Memcached is slow on failed lookups - impacts TagAwareAdapter #28248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Aug 23, 2018 · 2 comments
Closed

[Cache] Memcached is slow on failed lookups - impacts TagAwareAdapter #28248

nicolas-grekas opened this issue Aug 23, 2018 · 2 comments
Labels
Cache

Comments

@nicolas-grekas
Copy link
Member

When creating a tag for the first time, we currently don't create it on the backend until it is invalidated at least once.
This doesn't play well with memcached, which has slower response time for failed lookups.
Let's create this missing tag instead.

ping @andrerom maybe you'd like to give it a try? :)
@andrerom
Copy link
Contributor

I unfortunately don't have a setup for that right now, and we are rather looking into changing TagAware so there is no need to retrieve tags in the first place, and rather retrieve on invalidation only.

So there might be a PDOTagAwareAdapter coming soon for a community member somewhere in some form, as storing in database seemed the safest choice for now.

@xabbuh xabbuh added the Cache label Aug 23, 2018
@nicolas-grekas nicolas-grekas mentioned this issue Aug 23, 2018
Merged
@nicolas-grekas
Copy link
Member Author

The slow response time is actually related to the protocol. Fix is #28249

nicolas-grekas added a commit that referenced this issue Aug 24, 2018
@nicolas-grekas
bug #28249 [Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of m…
8860b66 
…isses (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of misses

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28248
| License       | MIT
| Doc PR        | -

As described in php-memcached-dev/php-memcached#24 and because we enable the binary protocol by default.

Commits
-------

8b59d17 [Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of misses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cache
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @andrerom @xabbuh