Skip to content

Cannot build container if framework.session is set to false #29217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fbourigault opened this issue Nov 14, 2018 · 1 comment
Closed

Cannot build container if framework.session is set to false #29217

fbourigault opened this issue Nov 14, 2018 · 1 comment
Labels
Bug SecurityBundle Status: Needs Review

Comments

@fbourigault
Copy link
Contributor

Symfony version(s) affected: 4.2.0-BETA1

Description
Upgrading to Symfony 4.2.0-BETA1 failed with the following error when framework.session is set to false:

In SecurityExtension.php line 70:

  Warning: array_key_exists() expects parameter 2 to be array, boolean given

Looks like it was introduced by #28446 which doesn't handle the false value.
@nicolas-grekas
Copy link
Member

Would you be able to submit a fix?

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 14, 2018
@fbourigault fbourigault mentioned this issue Nov 14, 2018
Merged
@nicolas-grekas nicolas-grekas removed this from the 4.2 milestone Nov 14, 2018
nicolas-grekas added a commit that referenced this issue Nov 15, 2018
@nicolas-grekas
bug #29224 [SecurityBundle] Fix remember-me cookie framework inherita…
5dc7e0c 
…nce when session is disabled (fbourigault)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29217
| License       | MIT
| Doc PR        | N/A

When `framework.session` configuration key is not an array, we ignore it.

Commits
-------

af81008 [SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug SecurityBundle Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicolas-grekas @fbourigault @xabbuh @carsonbot