[SecurityBundle] make remember-me cookies auto-secure + inherit their default config from framework.session.cookie_* #28446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea900dc to
2c23629
Compare
leofeyer
approved these changes
Sep 11, 2018
chalasr
approved these changes
Sep 11, 2018
chalasr
reviewed
Sep 11, 2018
| $rememberMeSecureDefault = false; | ||
| $rememberMeSameSiteDefault = null; | ||
|
|
||
| foreach ($container->getExtensions() as $name => $extension) { |
There was a problem hiding this comment.
if (isset($container->getExtensions()['framework'])) { instead?
2c23629 to
c48fbb4
Compare
fabpot
requested changes
Sep 12, 2018
|
As you add support in BrowserKit, shouldn't you also not send the cookie in the request if it is a samesite=strict one and we don't have a request to the same site as the last one in the history ? Otherwise, we don't actually support them. |
|
At least we can read the response cookie. I agree it would even be better to implement the samesite logic in browserkit. Let's open a separate issue for that? |
ff03aa0 to
9c153e4
Compare
|
Comments addressed. Status: needs review |
chalasr
reviewed
Sep 18, 2018
| @@ -11,6 +11,9 @@ CHANGELOG | |||
| or `Symfony\Component\Security\Core\Authentication\Token\RememberMeToken`. | |||
| * Added `Symfony\Bundle\SecurityBundle\DependencyInjection\Compiler\AddExpressionLanguageProvidersPass` | |||
| * Added `json_login_ldap` authentication provider to use LDAP authentication with a REST API. | |||
| * Made remember-me cookies inherit their default config from `framework.session.cookie_*` | |||
| and added an "auto" mode to their "secure" config option to make them secure on HTTPS automatically. | |||
|
|
|||
… default config from framework.session.cookie_*
9c153e4 to
6ec223b
Compare
leofeyer
approved these changes
Sep 18, 2018
fabpot
approved these changes
Sep 26, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 26, 2018
…+ inherit their default config from framework.session.cookie_* (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [SecurityBundle] make remember-me cookies auto-secure + inherit their default config from framework.session.cookie_* | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28338 | License | MIT | Doc PR | - Let's make it easier to have a good default security level, now for the remember-me cookie. Commits ------- 6ec223b [SecurityBundle] make remember-me cookies auto-secure + inherit their default config from framework.session.cookie_*
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make it easier to have a good default security level, now for the remember-me cookie.