Routes with trailing slash broken after upgrade to 4.1.8 #29363

jimmycleuren · 2018-11-28T14:01:30Z

Symfony version(s) affected: 4.1.8

Description
After the upgrade to 4.1.8, some routes with a trailing slash don't work anymore.

How to reproduce

/**
 * @Route("/user")
 */
class UserController extends Controller
{
    /**
     * @Route("/", name="user_index", methods="GET")
     */
    public function index(): Response
    {
    }
}

The route "/user/" works in 4.1.7, but gives the following error in 4.1.8:

2/2
Symfony\Component\HttpKernel\Exception\NotFoundHttpException:
No route found for "GET /user/"

  at vendor/symfony/http-kernel/EventListener/RouterListener.php:139
  at Symfony\Component\HttpKernel\EventListener\RouterListener->onKernelRequest(object(GetResponseEvent), 'kernel.request', object(TraceableEventDispatcher))
     (vendor/symfony/event-dispatcher/Debug/WrappedListener.php:111)
  at Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke(object(GetResponseEvent), 'kernel.request', object(EventDispatcher))
     (vendor/symfony/event-dispatcher/EventDispatcher.php:212)
  at Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(array(object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener)), 'kernel.request', object(GetResponseEvent))
     (vendor/symfony/event-dispatcher/EventDispatcher.php:44)
  at Symfony\Component\EventDispatcher\EventDispatcher->dispatch('kernel.request', object(GetResponseEvent))
     (vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:141)
  at Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch('kernel.request', object(GetResponseEvent))
     (vendor/symfony/http-kernel/HttpKernel.php:125)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
     (vendor/symfony/http-kernel/HttpKernel.php:66)
  at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
     (vendor/symfony/http-kernel/Kernel.php:188)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (public/index.php:37)

1/2
Symfony\Component\Routing\Exception\ResourceNotFoundException:

  at /tmp/cache/dev/srcDevDebugProjectContainerUrlMatcher.php:50
  at srcDevDebugProjectContainerUrlMatcher->match('/user')
     (vendor/symfony/routing/Matcher/UrlMatcher.php:107)
  at Symfony\Component\Routing\Matcher\UrlMatcher->matchRequest(object(Request))
     (vendor/symfony/routing/Router.php:262)
  at Symfony\Component\Routing\Router->matchRequest(object(Request))
     (vendor/symfony/http-kernel/EventListener/RouterListener.php:115)
  at Symfony\Component\HttpKernel\EventListener\RouterListener->onKernelRequest(object(GetResponseEvent), 'kernel.request', object(TraceableEventDispatcher))
     (vendor/symfony/event-dispatcher/Debug/WrappedListener.php:111)
  at Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke(object(GetResponseEvent), 'kernel.request', object(EventDispatcher))
     (vendor/symfony/event-dispatcher/EventDispatcher.php:212)
  at Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(array(object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener), object(WrappedListener)), 'kernel.request', object(GetResponseEvent))
     (vendor/symfony/event-dispatcher/EventDispatcher.php:44)
  at Symfony\Component\EventDispatcher\EventDispatcher->dispatch('kernel.request', object(GetResponseEvent))
     (vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:141)
  at Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch('kernel.request', object(GetResponseEvent))
     (vendor/symfony/http-kernel/HttpKernel.php:125)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
     (vendor/symfony/http-kernel/HttpKernel.php:66)
  at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
     (vendor/symfony/http-kernel/Kernel.php:188)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (public/index.php:37)

Additional context

Route is still visible in the debug:router command
Downgrade to 4.1.7 resolved the issue

The text was updated successfully, but these errors were encountered:

nicolas-grekas · 2018-11-28T19:55:21Z

Hello, I just tried a 4.1.8 app with this exact controller, it works well.
Could you please provide a reproducing app?

jimmycleuren · 2018-11-28T22:07:19Z

It seems I can only simulate it in my private repo as well. What I do notice, is that the route that is not working, is located in the $regexList of srcDevDebugProjectContainerUrlMatcher.php::doMatch.

But I don't know what the reason is for a route to move there instead of the initial switch statement and can't simulate it with a test app.

Anag13 · 2018-11-29T08:19:58Z

Hi, we can also confirm this from our end after the 4.1.8 update - none of the usual REST endpoints with trailing slashes work anymore and we experience the same behaviour as @jimmycleuren. Same as in his case, downgrading to 4.1.7 also fixes the issue.

Not sure if it helps in identifying the problem, but setting redirection support to false will also fix the issue.

// Does not work
$this->supportsRedirections = isset($interfaces[RedirectableUrlMatcherInterface::class]);

// Works same as before
$this->supportsRedirections = false;

nicolas-grekas · 2018-11-29T08:22:59Z

From @murnieza in #29287 (comment):

I have route /foo/{bar<.*>} and after this change /foo/ does not match my route anymore.

I'm on it.

nicolas-grekas · 2018-11-29T13:04:32Z

Hi everyone, please check #29373 and confirm it fixes your issues if you can.

This PR was merged into the 4.1 branch. Discussion ---------- [Routing] fix trailing slash redirection | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29363 | License | MIT | Doc PR | - Commits ------- fbaba23 [Routing] fix trailing slash redirection

julienfalque · 2018-11-29T21:04:12Z

I have a similar issue on a project where routes with and without trailing slash both exist. With symfony/routing v4.1.7 this worked fine but with v4.1.8, one of the routes never matches and a redirection to the other route occurs instead.

I added the following test to RedirectableUrlMatcherTest:

    public function testNoRedirectWhenBothRoutesExist()
    {
        $coll = new RouteCollection();
        $coll->add('foo_without_slash', new Route('/foo'));
        $coll->add('foo_with_slash', new Route('/foo/'));

        $matcher = $this->getUrlMatcher($coll);
        $matcher->expects($this->never())->method('redirect');
        $this->assertSame(array('_route' => 'foo_without_slash'), $matcher->match('/foo'));
        $this->assertSame(array('_route' => 'foo_with_slash'), $matcher->match('/foo/'));

        $coll = new RouteCollection();
        $coll->add('foo', new Route('/foo{trailingSlash}', array(), array('trailingSlash' => '/?')));

        $matcher = $this->getUrlMatcher($coll);
        $matcher->expects($this->never())->method('redirect');
        $this->assertSame(array('trailingSlash' => '', '_route' => 'foo'), $matcher->match('/foo'));
        $this->assertSame(array('trailingSlash' => '/', '_route' => 'foo'), $matcher->match('/foo/'));
    }

which passes on v4.1.7 but fails on v4.1.8. I wasn't able to make it pass without breaking other tests though.

nicolas-grekas · 2018-11-29T21:24:31Z

@julienfalque AFAIK that behavior is consistent with how 3.4 behaves. If I'm not wrong, this means you relied on a bug that is now fixed.

emodric · 2018-11-30T12:13:20Z

In my case, I get a redirection loop between the routes with and without the slash.

It is not fixed by #29380, however.

This PR was merged into the 4.1 branch. Discussion ---------- [Routing] fix greediness of trailing slash | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29363 | License | MIT | Doc PR | - Commits ------- eb6aee6 [Routing] fix greediness of trailing slash

nicolas-grekas · 2018-11-30T16:33:44Z

#29380 updated, should fix them all. Please report back if not.

xabbuh added Bug Routing labels Nov 28, 2018

carsonbot added the Status: Needs Review label Nov 28, 2018

pulsesalessolutions mentioned this issue Nov 28, 2018

UndefinedMethodException on login after upgrade to 4.1.8 #29365

Closed

nicolas-grekas mentioned this issue Nov 29, 2018

[Routing] fix trailing slash redirection #29373

Merged

nicolas-grekas mentioned this issue Nov 30, 2018

[Routing] fix greediness of trailing slash #29380

Merged

nicolas-grekas closed this as completed Nov 30, 2018

peterrehm mentioned this issue Dec 1, 2018

[Bug][BC break][Router] Multiple routes to same path with different methods #29410

Closed

Zombaya mentioned this issue Dec 10, 2018

Route with wildcard and different method can not be matched #29553

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Routes with trailing slash broken after upgrade to 4.1.8 #29363

Routes with trailing slash broken after upgrade to 4.1.8 #29363

jimmycleuren commented Nov 28, 2018 •

edited

Loading

nicolas-grekas commented Nov 28, 2018

jimmycleuren commented Nov 28, 2018

Anag13 commented Nov 29, 2018

nicolas-grekas commented Nov 29, 2018

nicolas-grekas commented Nov 29, 2018

julienfalque commented Nov 29, 2018

nicolas-grekas commented Nov 29, 2018 •

edited

Loading

emodric commented Nov 30, 2018

nicolas-grekas commented Nov 30, 2018

Routes with trailing slash broken after upgrade to 4.1.8 #29363

Routes with trailing slash broken after upgrade to 4.1.8 #29363

Comments

jimmycleuren commented Nov 28, 2018 • edited Loading

nicolas-grekas commented Nov 28, 2018

jimmycleuren commented Nov 28, 2018

Anag13 commented Nov 29, 2018

nicolas-grekas commented Nov 29, 2018

nicolas-grekas commented Nov 29, 2018

julienfalque commented Nov 29, 2018

nicolas-grekas commented Nov 29, 2018 • edited Loading

emodric commented Nov 30, 2018

nicolas-grekas commented Nov 30, 2018

jimmycleuren commented Nov 28, 2018 •

edited

Loading

nicolas-grekas commented Nov 29, 2018 •

edited

Loading