Skip to content

[Validator] Add the missing translations for the Serbian (Cyrillic) ("sr_Cyrl") locale #30188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 12, 2019 · 3 comments
Closed

[Validator] Add the missing translations for the Serbian (Cyrillic) ("sr_Cyrl") locale #30188

javiereguiluz opened this issue Feb 12, 2019 · 3 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2019 •
edited
Loading

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!

Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.sr_Cyrl.xlf file is missing the following translations compared to the original English file:

<trans-unit id="78">
    <source>An empty file is not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="79">
    <source>The host could not be resolved.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="80">
    <source>This value does not match the expected {{ charset }} charset.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="81">
    <source>This is not a valid Business Identifier Code (BIC).</source>
    <target>...</target>
</trans-unit>
<trans-unit id="82">
    <source>Error</source>
    <target>...</target>
</trans-unit>
<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="87">
    <source>This collection should contain only unique elements.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="88">
    <source>This value should be positive.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="89">
    <source>This value should be either positive or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="90">
    <source>This value should be negative.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="91">
    <source>This value should be either negative or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="92">
    <source>This value is not a valid timezone.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="93">
    <source>This password has been leaked in a data breach, it must not be used. Please use another password.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="94">
    <source>This value should be between {{ min }} and {{ max }}.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.
@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@unckleg
Copy link

unckleg commented Feb 13, 2019

Sending PR today ✋

@kunicmarko20
Copy link

This should be same as #30352, just in Cyrillic.

@KristijanKanalas
Copy link

I will do this over the weekend, I see that the latin version is also a bit outdated so I will make a PR for that too.

This was referenced Aug 9, 2019
Closed
Merged
Merged
@fabpot fabpot closed this as completed Aug 10, 2019
fabpot added a commit that referenced this issue Aug 10, 2019
@fabpot
minor #33097 Added translations in validator for Serbian Latin (Krist…
143789c 
…ijan Kanalas)

This PR was squashed before being merged into the 3.4 branch (closes #33097).

Discussion
----------

Added translations in validator for Serbian Latin

[Validator] Added translations
Related to #30188

Working on Serbian Cyrillic I saw that Latin translations are also missing some translations so this is a PR related to that. As said in the Cyrillic PR this should be able to be merged in all branches above 3.4, but I am not sure how to do that.

Commits
-------

fbe7362 Added translations in validator for Serbian Latin
fabpot added a commit that referenced this issue Aug 10, 2019
@fabpot
minor #33096 Added translations in validator for Serbian Cyrillic (Kr…
5e3bfad 
…istijan Kanalas)

This PR was squashed before being merged into the 3.4 branch (closes #33096).

Discussion
----------

Added translations in validator for Serbian Cyrillic

Resolves #30188

Should be able for merges in branches >3.4, not sure how to do that tho :(

Commits
-------

23d4a23 Added translations in validator for Serbian Cyrillic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging a pull request may close this issue.

Validator sr cyrillic translations
5 participants
@fabpot @javiereguiluz @unckleg @KristijanKanalas @kunicmarko20