[Validator] Update Serbian translation file #30352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Outdated
Show resolved
Hide resolved
| @@ -68,39 +68,39 @@ | |||
| </trans-unit> | |||
| <trans-unit id="17"> | |||
| <source>The mime type of the file is invalid ({{ type }}). Allowed mime types are {{ types }}.</source> | |||
| <target>Mime tip datoteke nije validan ({{ type }}). Dozvoljeni mime tipovi su {{ types }}.</target> | |||
| <target>MIME tip datoteke nije validan ({{ type }}). Dozvoljeni MIME tipovi su {{ types }}.</target> | |||
There was a problem hiding this comment.
Also not sure. I've found it in some books on Serbian it's written in full caps, which is why I changed it.
| </trans-unit> | ||
| <trans-unit id="23"> | ||
| <source>This value should not be null.</source> | ||
| <target>Vrednost ne treba da bude null.</target> | ||
| <target>Vrednost ne bi trebalo da bude prazna.</target> |
There was a problem hiding this comment.
Ah, hate that null and blank translates to the same word...
There was a problem hiding this comment.
Me too, but I couldn't find proper word for it.
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Outdated
Show resolved
Hide resolved
| </trans-unit> | ||
| <trans-unit id="79"> | ||
| <source>The host could not be resolved.</source> | ||
| <target>Nije moguće odrediti poslužitelja.</target> |
There was a problem hiding this comment.
not sure if anyone can understand this translation but it is valid...
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf
Outdated
Show resolved
Hide resolved
| </trans-unit> | ||
| <trans-unit id="81"> | ||
| <source>This is not a valid Business Identifier Code (BIC).</source> | ||
| <target>Ovo nije validan BIC.</target> |
There was a problem hiding this comment.
don't we want to add something that'd mean "Business Identifier Code"? BIC is clear enough? (same below)
There was a problem hiding this comment.
Don't know if we have a word for BIC, maybe we can literally translate it
There was a problem hiding this comment.
Correct, we don't have a word for it. I could translate it as Kodni identifikator banke, but it just sounds wrong. I think that BIC is enough.
kunicmarko20
approved these changes
Feb 23, 2019
|
Thank you @burnmaniac. |
fabpot
added a commit
that referenced
this pull request
Feb 23, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Update Serbian translation file | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30189 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | / <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> I am not sure about some translations, if someone could check these, I would appreciate it. Also, I've found that singular/plural translations have 3 translations. I am not sure if that's a mistake or not. I removed the third translation, but if I was wrong, I'll be happy to put it back. Commits ------- 9e9a57a [Validator] Update Serbian translation file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about some translations, if someone could check these, I would appreciate it.
Also, I've found that singular/plural translations have 3 translations. I am not sure if that's a mistake or not. I removed the third translation, but if I was wrong, I'll be happy to put it back.