Skip to content

[Validator] Add the missing translations for the Serbian (Latin) ("sr_Latn") locale #30189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Feb 12, 2019 · 2 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2019

IMPORTANT: this issue is reserved for new contributors, because we want to give the opportunity to people who want to contribute to Symfony but never found the right issue to do that.

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!


Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.sr_Latn.xlf file is missing the following translations compared to the original English file:

<trans-unit id="78">
    <source>An empty file is not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="79">
    <source>The host could not be resolved.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="80">
    <source>This value does not match the expected {{ charset }} charset.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="81">
    <source>This is not a valid Business Identifier Code (BIC).</source>
    <target>...</target>
</trans-unit>
<trans-unit id="82">
    <source>Error</source>
    <target>...</target>
</trans-unit>
<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.

@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@unckleg
Copy link

unckleg commented Feb 13, 2019

Sending PR today ✋

@burnmaniac
Copy link
Contributor

As there's no PR yet, I would like to take this, if I may?

@fabpot fabpot closed this as completed Feb 23, 2019
fabpot added a commit that referenced this issue Feb 23, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Update Serbian translation file

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30189  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | / <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
I am not sure about some translations, if someone could check these, I would appreciate it.

Also, I've found that singular/plural translations have 3 translations. I am not sure if that's a mistake or not. I removed the third translation, but if I was wrong, I'll be happy to put it back.

Commits
-------

9e9a57a [Validator] Update Serbian translation file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Development

No branches or pull requests

4 participants