[FrameworkBundle] cache:clear fails with doctrine annotations #40353
Comments
|
This must be because if #40338 You don't have |
|
Hm.. I've tested with and without |
Sure thing! reproducing this is a difficult because of how we do the tests over in maker. I'll shoot up a pr to that repo with the conditions that cause the error. |
fabpot
added a commit
that referenced
this issue
Mar 12, 2021
…ctrine/annotations:^1.13 (Nyholm) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] AnnotationsCacheWarmer should support doctrine/annotations:^1.13 | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40353 | License | MIT | Doc PR | The `AnnotationsCacheWarmer` is creating a cached a `new CachedReader` in the `doWarmUp()`. But this will fail if doctrine/cache is not installed. In #40338 I added the `kernel.cache_warmer` tag on `annotations.cache_warmer` service even though the doctrine/cache is not installed. This PR will make sure `AnnotationsCacheWarmer` is using the `PsrCacheReader` when available. This bug was not found in the tests because doctrine/cache is always installed. ---------- Big golden star to @jrushlow because you test dev-master. Commits ------- fb1cc72 [FrameworkBundle] AnnotationsCacheWarmer should support doctrine/annotations:^1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected: 5.x
Description
Command fails due to
How to reproduce
In a minimal Symfony 5.x app with
devdependencies either runbin/console cache:clear||composer require doctrine/annotations(triggers auto scripts in recipe)Possible Solution
Unknown
Additional context
Bug discovered in MakerBundles
devCI on PHP 7.4 && 8. Appears to be related to doctrine/annotations#404The text was updated successfully, but these errors were encountered: