[FrameworkBundle] AnnotationsCacheWarmer should support doctrine/annotations:^1.13 #40444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Mar 12, 2021
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
May 31, 2021
This PR was merged into the 5.3 branch. Discussion ---------- [FrameworkBundle] Remove redundant cache service | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follows #40444 and #41230. `@Nyholm` and I have fixed the same problem on different branches. Merging both efforts, we've created two cache services that are supposed to serve the same purpose. This PR suggests to remove one of them. Commits ------- 3b197fe [Framework] Remove redundant cache service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AnnotationsCacheWarmeris creating a cached anew CachedReaderin thedoWarmUp(). But this will fail if doctrine/cache is not installed. In #40338 I added thekernel.cache_warmertag onannotations.cache_warmerservice even though the doctrine/cache is not installed.This PR will make sure
AnnotationsCacheWarmeris using thePsrCacheReaderwhen available.This bug was not found in the tests because doctrine/cache is always installed.
Big golden star to @jrushlow because you test dev-master.