[RFC] Abandon FrameworkExtraBundle #44705

derrabus · 2021-12-18T18:48:23Z

Description

Since Symfony 2 sensio/framework-extra-bundle is the solution for adding annotation-magic to the application. Since then, some functionality has been moved to the core (e.g. annotation-based routing) and other functionality has been obsoleted by a core feature (param converters Vs. argument value providers).

FrameworkExtraBundle feels like a core-bundle but it's not as well maintained as we would expect a core bundle to be.

I think, it would be a good idea to review the feature set of the bundle and move commonly used functionality to the monorepo. Speaking for myself, that would be the security annotations like IsGranted as well as the Doctrine entity param converter (see #43854).

What do you think?

Example

No response

The text was updated successfully, but these errors were encountered:

fabpot · 2021-12-18T19:09:25Z

I agree.

garak · 2021-12-19T07:48:25Z

I don't get the logic. There's a set of optional features in a bundle that is not well maintained. The solution should be maintaining that bundle, not putting optional features in the core.

I think a strong point of Symfony is having a slim base and modularity, I hope it's not going to transform in a copy of Laravel.

wouterj · 2021-12-19T08:42:49Z

Let's not act as if moving 3 annotations as native PHP attributes to core will upset anyone please.

That being said, "the solution should be maintaining the bundle" is nicely said but not the practice. Apparently nobody is interest in maintaining the bundle (for years now).
So either it will be dead, we'll remove them from the official docs and that's it. Or we see value in some features and move the few attributes to core.

I'm all +1 for the latter.

javiereguiluz · 2021-12-19T08:51:21Z

@garak generally speaking I agree with you ... but in this particular case, I think the bundle was "wrong" since day one. I mean, these were so useful and common features that I never felt them as "extra features". In my opinion, they should've been "core/built-in features" since day one.

fabpot · 2021-12-19T21:22:18Z

These feature were in a bundle as annotations in phpdocs were controversial back then. Now that we have native annotations, it makes sense to move them to core. Add simple as that.

Nyholm · 2021-12-20T12:00:34Z

I agree with this as well.

@derrabus will you do/coordinate the work?

stof · 2021-12-20T12:14:13Z

As several features have not been migrated yet to the core, we cannot abandon the bundle yet (we probably cannot abandon it fully before the end of the 5.4 LTS, as the 5.4 branch won't have replacements).

However, I'm also in favor of bringing the remaining features to the core to abandon the bundle in the future

This PR was merged into the 6.1 branch. Discussion ---------- [HttpKernel] Add DateTimeValueResolver | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #44705 | License | MIT | Doc PR | symfony/symfony-docs#16562 This PR replaces the [DateTimeParamConverter](https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/src/Request/ParamConverter/DateTimeParamConverter.php) from the SensioFrameworkExtraBundle with a value resolver in the Symfony Core. Note that the behavior of the resolver is enabled by default when using the Symfony framework. Commits ------- dcc1228 [HttpKernel] Add DateTimeValueResolver

carsonbot · 2022-06-21T13:00:59Z

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

stof · 2022-06-21T13:04:13Z

@carsonbot keep this opened. The work is in progress in various places

… handle attributes on controllers (nicolas-grekas) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [HttpKernel] Add `ControllerEvent::getAttributes()` to handle attributes on controllers | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replacing #45457. Paving the way toward #44705 Commits ------- 0f2293c [HttpKernel] Add `ControllerEvent::getAttributes()` to handle attributes on controllers

nicolas-grekas · 2022-07-11T14:50:17Z

Help wanted (see #45415):

Cache [HttpKernel] Add #[Cache()] to describe the default HTTP cache headers on controllers #46880
Template [TwigBridge] Add #[Template()] to describe how to render arrays returned by controllers #46906
IsGranted [Security] Add #[IsGranted()] #46907 (see Improve #[IsGranted] #46912)
~~Security~~ (see Improve #[IsGranted] #46912)
Entity [DoctrineBridge] Add an Entity Argument Resolver #43854
~~ParamConverter~~ (see below)

This PR was merged into the 6.2 branch. Discussion ---------- [Security] Add `#[IsGranted()]` | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Part of #44705 | License | MIT | Doc PR | - Extracted from #45415 (and modernized a lot). I did not implement the proposals from Stof to keep this first iteration simple. I'd appreciate help to improve the attribute in a follow up PR 🙏 Commits ------- bf8d75e [Security] Add `#[IsGranted()]`

…nder arrays returned by controllers (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [TwigBridge] Add `#[Template()]` to describe how to render arrays returned by controllers | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Part of #44705 | License | MIT | Doc PR | - Extracted from #45415 (and modernized a lot). Unlike the``@Template`` annotation, this attribute mandates a template name as argument. This removes the need for any template-guesser logic, making things explicit. Using the attribute also turns `FormInterface` instances into `FormView`, adjusting the status code to 422 when a non-valid form is found in the parameters, similarly to what `AbstractController::render()` does. Commits ------- c252606 [TwigBridge] Add `#[Template()]` to describe how to render arrays returned by controllers

nicolas-grekas · 2022-07-12T07:54:48Z

ParamConverter ➡️ Symfony\Component\HttpKernel\Attribute\ParamConverter

We don't need this one, do we?

stof · 2022-07-12T08:15:33Z

indeed, I don't think we need it

…HTTP cache headers on controllers (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [HttpKernel] Add `#[Cache()]` to describe the default HTTP cache headers on controllers | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Part of #44705 | License | MIT | Doc PR | - Extracted from #45415 (and modernized a lot). I'd appreciate any help for porting the other attributes following this leading PR 🙏 Commits ------- acd4fa7 [HttpKernel] Add `#[Cache]` to describe the default HTTP cache headers on controllers

chalasr · 2022-07-21T12:10:16Z

The main features have been migrated to core. Let's iterate and deprecate FrameworkExtraBundle :)

stof · 2022-07-21T12:13:50Z

Well, let's wait for the release of the core feature first before deprecating FrameworkExtraBundle

arderyp · 2024-02-29T02:43:22Z

@stof I know this is an old closed issue but I have a relevant question.

I am on the latest 5.4.x. I just migrated from annotations to attributes. Everything is working great. grep is returning no instances of Sensio or sensio anywhere in my code. I dropped by sensio_framework_extra_bundle config. Everything is working.

And yet... when I remove the SensioFrameworkExtraBundle entry from config/bundles.php, my app breaks many routes with errors about being unable to map entity arguments in controller route parameters (like this).

It looks like ParamConverterListener is the source of my problem. Does Symfony not have a native replacement for that until 6.2?

derrabus · 2024-02-29T05:36:09Z

Please use our discussions board for support questions: https://github.com/symfony/symfony/discussions

carsonbot added the RFC RFC = Request For Comments (proposals about features that you want to be discussed) label Dec 18, 2021

javiereguiluz mentioned this issue Dec 18, 2021

[RFC] Move annotations from SensioFrameworkExtraBundle to Symfony core #25361

Closed

mbabker mentioned this issue Dec 19, 2021

[Meta] Impact of SensioFrameworkExtraBundle deprecation FriendsOfSymfony/FOSRestBundle#2354

Open

codedmonkey mentioned this issue Feb 13, 2022

Add native Http-based attribute support (Deprecate SensioFrameworkExtraBundle) #45415

Closed

7 tasks

derrabus mentioned this issue Feb 15, 2022

#[CurrentUser] : Unable to guess how to get a Doctrine instance from the request information for parameter "user". #40333

Closed

codedmonkey mentioned this issue Feb 17, 2022

[HttpKernel] Controller Attributes #45457

Closed

codedmonkey mentioned this issue Feb 28, 2022

[HttpKernel] Add DateTimeValueResolver #45589

Merged

derrabus mentioned this issue Mar 20, 2022

DenyAccessUnlessGranted route attribute #45774

Closed

nicolas-grekas mentioned this issue Apr 11, 2022

[HttpKernel] Add ControllerEvent::getAttributes() to handle attributes on controllers #46001

Merged

carsonbot added the Stalled label Jun 21, 2022

carsonbot removed the Stalled label Jun 21, 2022

Nyholm added the Keep open label Jun 21, 2022

This was referenced Jul 7, 2022

[HttpKernel] Add #[Cache()] to describe the default HTTP cache headers on controllers #46880

Merged

[TwigBridge] Add #[Template()] to describe how to render arrays returned by controllers #46906

Merged

[Security] Add #[IsGranted()] #46907

Merged

nicolas-grekas mentioned this issue Jul 12, 2022

Improve #[IsGranted] #46912

Closed

chalasr closed this as completed Jul 21, 2022

deguif mentioned this issue Nov 2, 2022

Allow to use translate controller without sensio/framework-extra-bundle schmittjoh/JMSTranslationBundle#569

Merged

boskos-q mentioned this issue Dec 26, 2022

[Security]IsGranted - Denied message 6.2 #48789

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Abandon FrameworkExtraBundle #44705

[RFC] Abandon FrameworkExtraBundle #44705

derrabus commented Dec 18, 2021

fabpot commented Dec 18, 2021

garak commented Dec 19, 2021

wouterj commented Dec 19, 2021 •

edited

Loading

javiereguiluz commented Dec 19, 2021 •

edited

Loading

fabpot commented Dec 19, 2021

Nyholm commented Dec 20, 2021

stof commented Dec 20, 2021

carsonbot commented Jun 21, 2022

stof commented Jun 21, 2022

nicolas-grekas commented Jul 11, 2022 •

edited

Loading

nicolas-grekas commented Jul 12, 2022 •

edited

Loading

stof commented Jul 12, 2022

chalasr commented Jul 21, 2022

stof commented Jul 21, 2022

arderyp commented Feb 29, 2024 •

edited

Loading

derrabus commented Feb 29, 2024

[RFC] Abandon FrameworkExtraBundle #44705

[RFC] Abandon FrameworkExtraBundle #44705

Comments

derrabus commented Dec 18, 2021

Description

Example

fabpot commented Dec 18, 2021

garak commented Dec 19, 2021

wouterj commented Dec 19, 2021 • edited Loading

javiereguiluz commented Dec 19, 2021 • edited Loading

fabpot commented Dec 19, 2021

Nyholm commented Dec 20, 2021

stof commented Dec 20, 2021

carsonbot commented Jun 21, 2022

stof commented Jun 21, 2022

nicolas-grekas commented Jul 11, 2022 • edited Loading

nicolas-grekas commented Jul 12, 2022 • edited Loading

stof commented Jul 12, 2022

chalasr commented Jul 21, 2022

stof commented Jul 21, 2022

arderyp commented Feb 29, 2024 • edited Loading

derrabus commented Feb 29, 2024

wouterj commented Dec 19, 2021 •

edited

Loading

javiereguiluz commented Dec 19, 2021 •

edited

Loading

nicolas-grekas commented Jul 11, 2022 •

edited

Loading

nicolas-grekas commented Jul 12, 2022 •

edited

Loading

arderyp commented Feb 29, 2024 •

edited

Loading