Skip to content

[Form] Move TypeTestCase classes to the Test namespace #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Feb 25, 2013 · 2 comments
Closed

[Form] Move TypeTestCase classes to the Test namespace #7175

wouterj opened this issue Feb 25, 2013 · 2 comments
Labels
Form

Comments

@wouterj
Copy link
Member

wouterj commented Feb 25, 2013

Yesterday, a new cookbook article was merged about Unit Testing your forms1.

There was a discussion about the place of the TypeTestCase class in the current workflow. Now it is documented, I think we should move these classes to their own Symfony\Component\Form\Test\Type namespace, instead of the current Symfony\Component\Form\Tests\Extension\Core\Type\.
@webmozart
Copy link
Contributor

TBD in 2.3

@wouterj
Copy link
Member Author

wouterj commented Apr 7, 2013

ping @bschussek does anyone have an update on this? (as 2.3 is coming soon)

@wouterj wouterj mentioned this issue Apr 12, 2013
Merged
2 tasks
fabpot added a commit that referenced this issue Apr 19, 2013
@fabpot
merged branch WouterJ/form_test_namespace (PR #7659)
56c13f9 
This PR was merged into the master branch.

Discussion
----------

[Form] Moved TypeTestCase to the Test namespace

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #7175
| License       | MIT
| Doc PR        | symfony/symfony-docs#2500

Todo:
 - [x] Make a Doc PR
 - [x] Update the changelog and UPGRADE-3.md files

As discussed in #7175, since this class is documented as a practise to test your form types, it's good to move it to the `Test` namespace.

I am not sure about the deprecation, I thought things deprecated in 2.3 are removed in 3.0. Also, I think we shouldn't trigger a E_USER_DEPRECATED message.
Please correct me if I'm wrong, it's my first PR for the core code.

Commits
-------

8da6129 Moved FormIntegrationTestCase and FormPerformanceTestCase to the Test namespace
e46f841 Moved TypeTestCase to it's own namespace
@fabpot fabpot closed this as completed Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @webmozart @wouterj