[Form] Moved TypeTestCase to the Test namespace #7659
Conversation
|
I had to use fully qualified names because you can't have an alias name which is equal to an existing class. The other failing tests in 5.3.* are not caused by this PR. |
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| use Symfony\Component\Form\CallbackTransformer; | |||
|
|
|||
| class CheckboxTypeTest extends TypeTestCase | |||
| class CheckboxTypeTest extends \Symfony\Component\Form\Test\Type\TypeTestCase | |||
There was a problem hiding this comment.
Use a use statement with an alias instead of a FQCN
There was a problem hiding this comment.
@stof I thought about that too, but I can't think of a good alias name. BaseTypeTestCase is wrong and TypeTestCase cannot be used.
There was a problem hiding this comment.
Given that, I think the FQCNs are fine.
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Form\Test\Type; |
There was a problem hiding this comment.
I think this can be moved to Symfony\Component\Form\Test directly, no?
|
Apart from the mentioned issues, this looks good. Could you please rebase and make the suggested changes? |
|
@bschussek I fixed/did the suggested changes, updated the doc PR and rebased it. I think it's ready to merge now. |
This PR was merged into the master branch. Discussion ---------- [Form] Moved TypeTestCase to the Test namespace | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #7175 | License | MIT | Doc PR | symfony/symfony-docs#2500 Todo: - [x] Make a Doc PR - [x] Update the changelog and UPGRADE-3.md files As discussed in #7175, since this class is documented as a practise to test your form types, it's good to move it to the `Test` namespace. I am not sure about the deprecation, I thought things deprecated in 2.3 are removed in 3.0. Also, I think we shouldn't trigger a E_USER_DEPRECATED message. Please correct me if I'm wrong, it's my first PR for the core code. Commits ------- 8da6129 Moved FormIntegrationTestCase and FormPerformanceTestCase to the Test namespace e46f841 Moved TypeTestCase to it's own namespace
Todo:
As discussed in #7175, since this class is documented as a practise to test your form types, it's good to move it to the
Testnamespace.I am not sure about the deprecation, I thought things deprecated in 2.3 are removed in 3.0. Also, I think we shouldn't trigger a E_USER_DEPRECATED message.
Please correct me if I'm wrong, it's my first PR for the core code.