[DataCollector] Improves the readability of the collected arrays in the profiler. #10150

sukei · 2014-01-28T08:59:03Z

It simply improves the readability of the collected arrays in the profiler:

before:

Array(date => Array(year => , month => , day => ), time => Array(hour => ))

after:

[
  date => [
      year => , 
      month => , 
      day => 
  ], 
  time => [
      hour => 
  ]
]

The errors are also highlighted in the form tree.

stloyd · 2014-01-28T09:10:06Z

It's new feature, so it must go against master branch, not 2.4.

sukei · 2014-01-28T09:36:42Z

It's not so new, the data are just presented differently. It could be released with the next 2.4.*.

fabpot · 2014-01-28T15:53:30Z

This PR is about 2 different changes. Can you submit 2 PRs and close this one? And yes, it's going to be merged into master, not 2.4.

sukei · 2014-01-28T21:07:02Z

Closed in favor of #10155. The second part is already part of the master.

Improves the readability of the collected arrays in the profiler.

64735b4

Highlights the form fields that contain errors in the tree.

778ffe7

Fixes the build.

dcae240

sukei closed this Jan 28, 2014

Provide feedback