Skip to content

[2.3] Fix phpunit test suite on travis #10824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

romainneutron
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #10821
License MIT

@@ -1,4 +1,4 @@
<?xml version="1.0" ?>
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests were failing because of this, see https://travis-ci.org/romainneutron/symfony/jobs/24088967

@romainneutron
Copy link
Contributor Author

@webmozart We have a test that fails on PHP 5.5 and 5.6, it also fails on my computer (PHP 5.5.11) see https://travis-ci.org/symfony/symfony/builds/24090008

1) Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest::testTrimUtf8 with data set "General category: Separator" (array('0020', '00A0', '1680', '180E', '2000', '2001', '2002', '2003', '2004', '2005', '2006', '2007', '2008', '2009', '200A', '2028', '2029', '202F', '205F', '3000'))
TrimListener should trim character(s): 0020, 00A0, 1680, 180E, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 200A, 2028, 2029, 202F, 205F, 3000
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-ab
-cd
+᠎           

   ab
+cd   ᠎
/home/travis/build/symfony/symfony/src/Symfony/Component/Form/Tests/Extension/Core/EventListener/TrimListenerTest.php:68

That's weird as none of the test or the listener have been changed for a while.
Are you sure about the regexp in https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Core/EventListener/TrimListener.php#L33 ?

@romainneutron
Copy link
Contributor Author

@stof I've tried to self-update PHPUnit in #10826, but it did not solve the issue

@stof
Copy link
Member

stof commented Apr 30, 2014

@romainneutron this is because 4.0.19 was not yet released. --self-update goes to the latest stable release in PHPUnit, not to the latest commit. The 4.0.19 phar on http://phar.phpunit.de/ is only 7 minutes old. So try again now :)

@stof
Copy link
Member

stof commented Apr 30, 2014

I suggest using #10826 instead as downloading a phar will be faster than running a composer installation

@romainneutron
Copy link
Contributor Author

@stof what about your comment about openssl (#10826 (comment)), #10826 bypasses tests on 5.3

@stof
Copy link
Member

stof commented Apr 30, 2014

yeah, I saw it after commented here. --self-update does not fallback to non-SSL in PHPUnit as done in composer. It is a shame that Travis guys did not manage to compile PHP 5.3.3 with openssl properly.

@romainneutron
Copy link
Contributor Author

@loicfrering do you think it's possible to add openssl to PHP 5.3.3 recipe?

@romainneutron
Copy link
Contributor Author

closed in favor of #10826

@romainneutron romainneutron deleted the phpunit-travis branch April 30, 2014 15:30
@loicfrering
Copy link

@romainneutron we had to drop openssl on 5.3.3 due to compilation issues with the recent versions of OpenSSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants