Adding node name getter with tests #11351
Conversation
|
this needs a rebase |
|
I think the name should be |
|
@stof , I choose the name 'name' to be more consistent with other methods, like attr, text, and html that are all relevant to the node and not the attributes. Do you think that it is better to leave that consistence behind just to make the functionality more clear? |
|
Also, I realised that I did not read all the documentation on how to contribute to symfony so after deciding on the name I'll make the necessary adjustments. |
|
@fejese but Btw, if you want to make the necessary adjustments, you will have to create a new PR, as this one is opened from @fabpot's fork. |
|
@stof, good point, I'll rename it. I think |
|
replaced by #11426 |
This PR was merged into the 2.6-dev branch. Discussion ---------- [DomCrawler] Added node name getter [DomCrawler] Added node name getter Based on the use case came up in a SO question (http://stackoverflow.com/questions/22564465/getting-the-tag-name-of-a-element-crawled-with-domcrawler-in-php) I propose a new helper function to get the name of the active node | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#4039 (Follow up of #11351) Commits ------- 2fee576 [DomCrawler] Added node name getter
This PR was submitted on the symfony/DomCrawler read-only repository and moved automatically to the main Symfony repository (closes symfony/dom-crawler#17).
Based on the use case came up in a SO question (http://stackoverflow.com/questions/22564465/getting-the-tag-name-of-a-element-crawled-with-domcrawler-in-php) I propose a new helper function to get the name of the active node