[2.4] sync master translations with 2.4 #11618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand your PR. You are labelling it as |
| @@ -175,7 +175,7 @@ | |||
| <target>L'altura de la imatge és massa petita ({{ height }}px). L'altura mínima requerida són {{ min_height }}px.</target> | |||
| </trans-unit> | |||
| <trans-unit id="47"> | |||
| <source>This value should be the user current password.</source> | |||
| <source>This value should be the user's current password.</source> | |||
There was a problem hiding this comment.
if the goal is to merge in 2.4, this change must not be included (we haven't changed the source in patch releases for 2.4 as it would be a BC break)
|
@1emming I didn't check all of the other related files yet, but it seems to me that they do exist in 2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync translations of master that are missing in 2.4