[Form] Added the 'range' FormType #12067
Conversation
| @@ -1105,3 +1105,4 @@ Symfony2 is the result of the work of many people who made the code better | |||
| - Erik Saunier (snickers) | |||
| - Matej Žilák (teo_sk) | |||
| - Vladislav Vlastovskiy (vlastv) | |||
| - Joshua Thijssen (jaytaph) | |||
There was a problem hiding this comment.
I was not sure. Should I remove the line from the PR?
|
One thing I didn't want to change, is the fact that the validatorGuesser guesses "Range" constraints to be a It might make sense to change this into this new |
| @@ -3,9 +3,9 @@ CHANGELOG | |||
|
|
|||
| 2.6.0 | |||
| ----- | |||
|
|
|||
|
Please add tests for your new form type. and this will make you notice that you forgot to implement the support of the range type in the PHP form theme |
|
@stof: ok.. are there currently formtype tests available, as I cannot find them. Maybe i'm looking in the wrong place? |
|
@jaytaph You can have a look at the tests in |
|
Any news on this PR? |
|
Thanks @jaytaph for working on this feature, this is much appreciated. |
This PR was merged into the 2.8 branch. Discussion ---------- HTML5 range documentation Hi, | Q | A | ------------- | --- | Doc fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | [#5439] | Code PR | [12607] | License | MIT I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes #5439 . Need some help on moving for I am really new to the documentation. The current issues I feel is whether we need to add Basic usage or is that only reference ? I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing. I have looked into other types also and almost all are some what similar. Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it . Thank you. Commits ------- 2863079 Fix moving the mapped down as per @xabbuh abf3e8e Fix the rendering issue 3c6ff76 Fix issues reported by @snoek09 . Thank you. a2c3f21 Make the necessary changes mentioned by @xabbuh and add example for form d4d1f12 Starting with range documentation
Implemented the "range" FormType.