[Form] Add "range" type #11979 #12693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know what more things are needed here. From my side, wondering if we should add a validator or something for dealing not supporting this kind of field type. They seem to present a textfield... |
f4d4b08 to
feb9257
Compare
|
applied the patch suggested by the coding standards sniffer. didn't know you need a comma after the last pair of key vals in an array. also added pull request header in the comment. |
|
2 things are missing here:
|
|
Ok. I will try to do them during the next hours and will ping you about. |
|
@crevillo ping |
|
Haven't found time. Feel free to take over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my approach to #11979
It allows to use range field type with symfony