Skip to content

Update phpunit.xml.dist #12133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update phpunit.xml.dist #12133

wants to merge 1 commit into from

Conversation

kanasayrus
Copy link

Include in phpunit.xml.dist UnitTest Created on vendor. I need to replace what I insert with shortest expression using astrixes. I will do it later. It will reduce number of minor error on Insight.

Include in phpunit.xml.dist UnitTest Created on vendor. I need to replace what I insert with shortest expression using astrixes. I will do it later.
@stof
Copy link
Member

stof commented Oct 5, 2014

This makes absolutely no sense:

  • our goal is to run the Symfony testsuite, not the testsuite of all other libraries we rely on
  • this setup is entirely broken. Each project testsuite has its own dependencies, which are installed when the project itself is the root. They are not meant to be run when they are installed as dependency of other projects.

Btw, this does not affect Travis because of the way our Travis setup is done, so the only effect is forbidding running tests locally.

Btw, I don't see how trying to run tests for vendors could reduce the number of minor error on Insight. It is totally unrelated

@stof stof closed this Oct 5, 2014
@kanasayrus
Copy link
Author

Hello.

I had minor errors on my project due to the fact that unitTEST in vendor
are not declared in phpunot.xml.dist. Once I add them i highly reduces the
number of minor error.
Le 5 oct. 2014 12:00, "Christophe Coevoet" notifications@github.com a
écrit :

Closed #12133 #12133.


Reply to this email directly or view it on GitHub
#12133 (comment).

@stof
Copy link
Member

stof commented Oct 5, 2014

@kanasayrus IMO, this means you have another issue in your project. May it be that you are configuring the excluded paths of your project explicitly on Insight, and you are not excluding vendors anymore ?

Running tests for all dependencies as part of our testsuite is both useless (all of these projects are already tested) and broken (as we are not setting up their testing environment)

@kanasayrus
Copy link
Author

Hi Stof,

I had this error on Insight :

Rule #32-094 PHPUnit should be able to run all PHP tests
The documentation is not yet ready for this rule. Rule settings

To customize this rule, you can add the following section to your project
configuration:

rules:

...

php.neglected_tests:

enabled: true

Do you mean uses the rule to exclude vendors unitTests?

2014-10-05 13:26 GMT+01:00 Christophe Coevoet notifications@github.com:

@kanasayrus https://github.com/kanasayrus IMO, this means you have
another issue in your project. May it be that you are configuring the
excluded paths of your project explicitly on Insight, and you are not
excluding vendors anymore ?

Running tests for all dependencies as part of our testsuite is both
useless (all of these projects are already tested) and broken (as we are
not setting up their testing environment)


Reply to this email directly or view it on GitHub
#12133 (comment).

Asmâa ELOUERKHAOUI
Phd Student
UFR Informatics and Telecommunication
GSCM_LRIT
B.P. 1014 Faculty of Sciences Rabat-Morocco
GSM : +212 669 46 63 59
E-mail : elouerkhaoui@gmail.com
URL : http://www.fsr.ac.ma/GSCM/

@stof
Copy link
Member

stof commented Oct 5, 2014

@kanasayrus but Insight should ignore your vendor folder, and so should not complain about vendor tests. Look at your global_exclude_dirs config

@kanasayrus
Copy link
Author

Maybe you are right Stof, I'll check that later and will keep you informed.
Thanks anyway and have a nice end of week-end.

2014-10-05 14:42 GMT+01:00 Christophe Coevoet notifications@github.com:

@kanasayrus https://github.com/kanasayrus but Insight should ignore
your vendor folder, and so should not complain about vendor tests. Look at
your global_exclude_dirs config


Reply to this email directly or view it on GitHub
#12133 (comment).

Asmâa ELOUERKHAOUI
Phd Student
UFR Informatics and Telecommunication
GSCM_LRIT
B.P. 1014 Faculty of Sciences Rabat-Morocco
GSM : +212 669 46 63 59
E-mail : elouerkhaoui@gmail.com
URL : http://www.fsr.ac.ma/GSCM/

@kanasayrus
Copy link
Author

Just by curiosity, if we exclude files from analyses this is not consider
as we pretend vendor do not need to be analyzed?

2014-10-05 14:48 GMT+01:00 El ouerkhaoui Asmâa elouerkhaoui@gmail.com:

Maybe you are right Stof, I'll check that later and will keep you
informed. Thanks anyway and have a nice end of week-end.

2014-10-05 14:42 GMT+01:00 Christophe Coevoet notifications@github.com:

@kanasayrus https://github.com/kanasayrus but Insight should ignore
your vendor folder, and so should not complain about vendor tests. Look at
your global_exclude_dirs config


Reply to this email directly or view it on GitHub
#12133 (comment).

Asmâa ELOUERKHAOUI
Phd Student
UFR Informatics and Telecommunication
GSCM_LRIT
B.P. 1014 Faculty of Sciences Rabat-Morocco
GSM : +212 669 46 63 59
E-mail : elouerkhaoui@gmail.com
URL : http://www.fsr.ac.ma/GSCM/

Asmâa ELOUERKHAOUI
Phd Student
UFR Informatics and Telecommunication
GSCM_LRIT
B.P. 1014 Faculty of Sciences Rabat-Morocco
GSM : +212 669 46 63 59
E-mail : elouerkhaoui@gmail.com
URL : http://www.fsr.ac.ma/GSCM/

@stof
Copy link
Member

stof commented Oct 5, 2014

@kanasayrus It means you don't want violations to be reported in these files, which is the right thing to do as they are separate projects. The score of your project is meant to be based on your code, not on code living in vendor libraries outside of your control. This is why the default value for the excluded dirs (when you don't configure it yourself) contains the vendor folder.
If you want to get the analysis for your vendors to see their violations, it should be done by analyzing them as projects on their own (or by looking at Insight projects registered for them by their maintainers as many of them may be registered already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants