-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Update phpunit.xml.dist #12133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update phpunit.xml.dist #12133
Conversation
Include in phpunit.xml.dist UnitTest Created on vendor. I need to replace what I insert with shortest expression using astrixes. I will do it later.
This makes absolutely no sense:
Btw, this does not affect Travis because of the way our Travis setup is done, so the only effect is forbidding running tests locally. Btw, I don't see how trying to run tests for vendors could reduce the number of minor error on Insight. It is totally unrelated |
Hello. I had minor errors on my project due to the fact that unitTEST in vendor
|
@kanasayrus IMO, this means you have another issue in your project. May it be that you are configuring the excluded paths of your project explicitly on Insight, and you are not excluding vendors anymore ? Running tests for all dependencies as part of our testsuite is both useless (all of these projects are already tested) and broken (as we are not setting up their testing environment) |
Hi Stof, I had this error on Insight : Rule #32-094 PHPUnit should be able to run all PHP tests To customize this rule, you can add the following section to your project rules: ...php.neglected_tests:
Do you mean uses the rule to exclude vendors unitTests? 2014-10-05 13:26 GMT+01:00 Christophe Coevoet notifications@github.com:
Asmâa ELOUERKHAOUI |
@kanasayrus but Insight should ignore your vendor folder, and so should not complain about vendor tests. Look at your |
Maybe you are right Stof, I'll check that later and will keep you informed. 2014-10-05 14:42 GMT+01:00 Christophe Coevoet notifications@github.com:
Asmâa ELOUERKHAOUI |
Just by curiosity, if we exclude files from analyses this is not consider 2014-10-05 14:48 GMT+01:00 El ouerkhaoui Asmâa elouerkhaoui@gmail.com:
Asmâa ELOUERKHAOUI |
@kanasayrus It means you don't want violations to be reported in these files, which is the right thing to do as they are separate projects. The score of your project is meant to be based on your code, not on code living in vendor libraries outside of your control. This is why the default value for the excluded dirs (when you don't configure it yourself) contains the vendor folder. |
Include in phpunit.xml.dist UnitTest Created on vendor. I need to replace what I insert with shortest expression using astrixes. I will do it later. It will reduce number of minor error on Insight.