[Hackday][Validator] Add deprecated logs on addViolation() and addViolationAt() methods. #12714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmartin
commented
Nov 29, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12686 |
| License | MIT |
| Doc PR |
26d2fbc to
9043526
Compare
| 'as of Symfony 2.5 and will be removed in Symfony 3.0. Please use buildViolation() instead.', | ||
| E_USER_DEPRECATED | ||
| ); | ||
|
|
There was a problem hiding this comment.
I'm not sure if this log is useful because the whole class and the interface are deprecated, as they were moved to the Symfony\Component\Validator\Context namespace.
|
re #12684 |
|
The deprecation warnings were added in the wrong class (the BC layers are in the child class). given no update was done here by the author, I sent a PR myself with the appropriate fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.