[Validator] Add deprecated logs on addViolation() and addViolationAt() methods #13219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +58,11 @@ public function __construct(ValidatorInterface $validator, $root, MetadataFactor | |||
| public function addViolation($message, array $parameters = array(), $invalidValue = null, $plural = null, $code = null) | |||
| { | |||
| if (func_num_args() > 2) { | |||
| trigger_error( | |||
e840634 to
2ea9ce1
Compare
|
updated |
| @@ -77,6 +79,11 @@ public function addViolation($message, array $parameters = array(), $invalidValu | |||
| */ | |||
| public function addViolationAt($subPath, $message, array $parameters = array(), $invalidValue = null, $plural = null, $code = null) | |||
| { | |||
| trigger_error( | |||
|
Actually, #13060 is already covering this, so I'm closing this PR in favor of the PR handling the deprecation warnings in batch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #12714 by adding the deprecation warnings in the right class and updating them to match our standards.