Trigger error for the deprecated methods in LegacyExecutionContext. #12718
Conversation
Lumbendil
commented
Nov 29, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12688 |
| License | MIT |
| Doc PR | none |
| @@ -49,6 +49,11 @@ public function __construct(ValidatorInterface $validator, $root, MetadataFactor | |||
| $translationDomain | |||
| ); | |||
|
|
|||
| trigger_error('The LegacyExecutionContext and will be removed.' | |||
There was a problem hiding this comment.
please put messages on single long line
| @@ -49,6 +49,8 @@ public function __construct(ValidatorInterface $validator, $root, MetadataFactor | |||
| $translationDomain | |||
| ); | |||
|
|
|||
| trigger_error('The LegacyExecutionContext and will be removed. You should use the new ExecutionContext, which now handles the functionallity of this class.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
The first sentence doesn't seem to be complete.
| @@ -49,6 +49,8 @@ public function __construct(ValidatorInterface $validator, $root, MetadataFactor | |||
| $translationDomain | |||
| ); | |||
|
|
|||
| trigger_error('The LegacyExecutionContext has been deprecated and will be removed. You should use the new ExecutionContext, which now handles the functionality of this class.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
deprecation messages should use fully qualified class names (LegacyExecutionContext is not a class name). You can rely on __CLASS__ to make it easier
There was a problem hiding this comment.
This warning is actually wrong, because it would be trigger each time the validator is used in a Symfony project.
|
Maybe we should not add any warning on this one: it's an internal class that nobody should use but the internal BC layer. |
|
@nicolas-grekas users could be getting the metadata in order to modify it, so I think a warning should be given, so users move to the new ExecutionContext class. |