Skip to content

Trigger error for the deprecated methods in LegacyExecutionContext. #12718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Trigger error for the deprecated methods in LegacyExecutionContext. #12718

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da27434
Trigger error for the deprecated methods in LegacyExecutionContext.
Lumbendil Nov 29, 2014
ebb35e9
Changed the errors to a single line.
Lumbendil Nov 29, 2014
e14053a
Fix phrasing.
Lumbendil Nov 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/Validator/Context/LegacyExecutionContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ public function __construct(ValidatorInterface $validator, $root, MetadataFactor
$translationDomain
);

trigger_error('The LegacyExecutionContext has been deprecated and will be removed. You should use the new ExecutionContext, which now handles the functionality of this class.', E_USER_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation messages should use fully qualified class names (LegacyExecutionContext is not a class name). You can rely on __CLASS__ to make it easier

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning is actually wrong, because it would be trigger each time the validator is used in a Symfony project.


$this->metadataFactory = $metadataFactory;
}

Expand Down Expand Up @@ -151,6 +153,8 @@ public function validateValue($value, $constraints, $subPath = '', $groups = nul
*/
public function getMetadataFactory()
{
trigger_error('The method getMetadataFactory has been deprecated and will be removed. You have to use getValidator() to access the metadata, which can be accessed with the same method than with the MetadataFactory.', E_USER_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should give the FQCN of the method (use __METHOD__ for that)


return $this->metadataFactory;
}
}