[DEPRECATION] Added deprecated trigger for ApacheMatcherDumper and ApacheUrlMatcher #12728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blamh
commented
Nov 29, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12655 |
| License | MIT |
| Doc PR |
| @@ -32,6 +32,7 @@ | |||
| */ | |||
| public function __construct(RouteCollection $routes) | |||
| { | |||
| trigger_error('The Symfony\Component\Routing\Matcher\Dumper\MatcherDumper is deprecated since it\'s hard to replicate the behaviour of the PHP implementation and the performance gains are minimal.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
this class is not deprecated
There was a problem hiding this comment.
Mybad. Deprecated wrong class. Fixed.
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| namespace Symfony\Component\Routing\Matcher; | |||
|
|
|||
| trigger_error('The Symfony\Component\Routing\Matcher\Dumper\ApacheUrlMatcher is deprecated since it\'s hard to replicate the behaviour of the PHP implementation and the performance gains are minimal.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Can you add something along the lines of "is deprecated since version 2.x and will be removed in 3.0."?
|
Thank you @blamh. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2014
…Dumper and ApacheUrlMatcher (blamh) This PR was merged into the 2.7 branch. Discussion ---------- [DEPRECATION] Added deprecated trigger for ApacheMatcherDumper and ApacheUrlMatcher | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12655 | License | MIT | Doc PR | Commits ------- 963615a Added deprecated trigger for ApacheMatcherDumper and ApacheUrlMatcher
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Drop support for ApacheRequest | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `ApacheUrlMatcher` has been [deprecated in 2.7](#12728) and removed in 3.0 I think we forgot to remove this class too. This class in never used in symfony, and there are no more reference in the documentation. Commits ------- f82e28c [HttpFoundation] Deprecated ApacheRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.